From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932380AbcECHYK (ORCPT ); Tue, 3 May 2016 03:24:10 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:48025 "EHLO e06smtp13.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750773AbcECHX4 (ORCPT ); Tue, 3 May 2016 03:23:56 -0400 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: schwidefsky@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Tue, 3 May 2016 09:23:48 +0200 From: Martin Schwidefsky To: Heiko Carstens Cc: Anna-Maria Gleixner , linux-kernel@vger.kernel.org, rt@linutronix.de, linux-s390@vger.kernel.org Subject: Re: [PATCH v2] s390/cpum_sf: Remove superfluous SMP function call Message-ID: <20160503092348.09a9e71c@mschwide> In-Reply-To: <20160502104356.GB3974@osiris> References: <1462179612-55035-1-git-send-email-anna-maria@linutronix.de> <20160502104356.GB3974@osiris> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16050307-0013-0000-0000-00000F941D6E Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 May 2016 12:43:56 +0200 Heiko Carstens wrote: > On Mon, May 02, 2016 at 11:00:12AM +0200, Anna-Maria Gleixner wrote: > > Since commit 3b9d6da67e11 ("cpu/hotplug: Fix rollback during error-out > > in __cpu_disable()") it is ensured that callbacks of CPU_ONLINE and > > CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP > > function calls are no longer required. > > > > Replace smp_call_function_single() with a direct call of > > setup_pmc_cpu(). To keep the calling convention, interrupts are > > explicitly disabled around the call. > > > > Cc: Martin Schwidefsky > > Cc: Heiko Carstens > > Cc: linux-s390@vger.kernel.org > > Signed-off-by: Anna-Maria Gleixner > > --- > > Changes in v2: > > - Adapt referenced commit in commit message > > > > arch/s390/kernel/perf_cpum_sf.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > Acked-by: Heiko Carstens > > Same here: Martin, can you pick this one up, please? Applied as well. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.