From: Kalle Valo <kvalo@codeaurora.org>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: unlisted-recipients:"; (no To-header on input) Denys Vlasenko"
<dvlasenk@redhat.com>, Larry Finger <Larry.Finger@lwfinger.net>,
Chaoming Li <chaoming_li@realsil.com.cn>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: rtlwifi: rtl818x: Deinline indexed IO functions, save 21568 bytes
Date: Tue, 3 May 2016 10:05:57 +0000 (UTC) [thread overview]
Message-ID: <20160503100557.76E7A60239@smtp.codeaurora.org> (raw)
In-Reply-To: <1461593872-6296-1-git-send-email-dvlasenk@redhat.com>
> rtl818x_ioread8_idx: 151 bytes, 29 calls
> rtl818x_ioread16_idx: 151 bytes, 11 calls
> rtl818x_ioread32_idx: 151 bytes, 5 calls
> rtl818x_iowrite8_idx: 157 bytes, 117 calls
> rtl818x_iowrite16_idx: 158 bytes, 74 calls
> rtl818x_iowrite32_idx: 157 bytes, 22 calls
>
> Each of these functions has a pair of mutex lock/unlock ops,
> both of these ops perform atomic updates of memory (on x86, it boils down to
> "lock cmpxchg %reg,mem" insn), which are 4-8 times more expensive than call+return.
>
> text data bss dec hex filename
> 95894242 20860288 35991552 152746082 91ab862 vmlinux_before
> 95872674 20860320 35991552 152724546 91a6442 vmlinux
>
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> CC: Larry Finger <Larry.Finger@lwfinger.net>
> CC: Chaoming Li <chaoming_li@realsil.com.cn>
> CC: linux-wireless@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
prev parent reply other threads:[~2016-05-03 10:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 14:17 [PATCH] rtlwifi: rtl818x: Deinline indexed IO functions, save 21568 bytes Denys Vlasenko
2016-05-03 10:05 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503100557.76E7A60239@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=dvlasenk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox