From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932578AbcECLkm (ORCPT ); Tue, 3 May 2016 07:40:42 -0400 Received: from down.free-electrons.com ([37.187.137.238]:49577 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755791AbcECLkl (ORCPT ); Tue, 3 May 2016 07:40:41 -0400 Date: Tue, 3 May 2016 13:40:38 +0200 From: Alexandre Belloni To: Sudip Mukherjee Cc: Alessandro Zummo , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [PATCH v2] rtc: stmp3xxx: print message on error Message-ID: <20160503114038.GG2335@piout.net> References: <1462043490-21448-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462043490-21448-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/04/2016 at 20:11:30 +0100, Sudip Mukherjee wrote : > stmp3xxx_wdt_register() can fail as platform_device_alloc() or > platform_device_add() can fail. But when it fails it failed silently. > Lets print out an error message on failure so that user will atlest > know that there was some error. > > Signed-off-by: Sudip Mukherjee > --- > > v1 - returned error while failing in the probe. > > drivers/rtc/rtc-stmp3xxx.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com