From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932945AbcECMVL (ORCPT ); Tue, 3 May 2016 08:21:11 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:34230 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750728AbcECMVJ (ORCPT ); Tue, 3 May 2016 08:21:09 -0400 Date: Tue, 3 May 2016 14:21:07 +0200 From: Johan Hovold To: Konstantin Shkolnyy Cc: David Laight , "'Konstantin Shkolnyy'" , "johan@kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [EXT] RE: [PATCH v2 2/3] USB: serial: cp210x: Added comments to CRTSCTS flag code. Message-ID: <20160503122107.GN25025@localhost> References: <1461982943-19664-1-git-send-email-konstantin.shkolnyy@gmail.com> <063D6719AE5E284EB5DD2968C1650D6D5F4B2EEA@AcuExch.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 03, 2016 at 12:11:53PM +0000, Konstantin Shkolnyy wrote: > > -----Original Message----- > > From: linux-usb-owner@vger.kernel.org [mailto:linux-usb- > > owner@vger.kernel.org] On Behalf Of David Laight > > Sent: Tuesday, May 03, 2016 04:44 > > To: 'Konstantin Shkolnyy'; johan@kernel.org > > Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject: [EXT] RE: [PATCH v2 2/3] USB: serial: cp210x: Added comments to > > CRTSCTS flag code. > > > > From: Konstantin Shkolnyy > > > Sent: 30 April 2016 03:22 > > > Replaced magic numbers used in the CRTSCTS flag code with symbolic > > names > > > from the chip specification. > > > > > > Signed-off-by: Konstantin Shkolnyy > > > --- > > > Changes in v2: > > > Improved CRTSCTS fix based on feedback. Dropped get_termios error > > handling. > > > > > > drivers/usb/serial/cp210x.c | 93 > > +++++++++++++++++++++++++++++++++------------ > > > 1 file changed, 69 insertions(+), 24 deletions(-) > > > > > > diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c > > ... > > > +/* cp210x_flow_ctl::ulControlHandshake */ > > > +#define SERIAL_DTR_MASK 0x00000003 > > > +#define SERIAL_CTS_HANDSHAKE 0x00000008 > > > +#define SERIAL_DSR_HANDSHAKE 0x00000010 > > > +#define SERIAL_DCD_HANDSHAKE 0x00000020 > > > +#define SERIAL_DSR_SENSITIVITY 0x00000040 > > ... > > > > I'd have thought the names ought to start CP210X_ > > These names are inherited from the Labs chip spec. Yes, but it's still a good idea to add a CP210X_ prefix to avoid any confusion with the serial-core defines. Thanks, Johan