From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756439AbcECU0N (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 May 2016 16:26:13 -0400
Received: from mail-pa0-f54.google.com ([209.85.220.54]:36490 "EHLO
	mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756181AbcECU0L convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 May 2016 16:26:11 -0400
Date: Tue, 3 May 2016 13:26:23 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Linus =?UTF-8?B?TMO8c3Npbmc=?= <linus.luessing@c0d3.blue>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
        bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        Simon Wunderlich <sw@simonwunderlich.de>
Subject: Re: [PATCH net] bridge: fix igmp / mld query parsing
Message-ID: <20160503132623.59cf54fb@xeon-e3>
In-Reply-To: <1462306734-4183-1-git-send-email-linus.luessing@c0d3.blue>
References: <1462306734-4183-1-git-send-email-linus.luessing@c0d3.blue>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue,  3 May 2016 22:18:54 +0200
Linus Lüssing <linus.luessing@c0d3.blue> wrote:

> diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> index 03661d9..7105cdf 100644
> --- a/net/bridge/br_multicast.c
> +++ b/net/bridge/br_multicast.c
> @@ -1271,6 +1271,7 @@ static int br_ip4_multicast_query(struct net_bridge *br,
>  	unsigned long max_delay;
>  	unsigned long now = jiffies;
>  	__be32 group;
> +	int offset = skb_transport_offset(skb);
shouldn't this be unsigned?