From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756023AbcECNsS (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 May 2016 09:48:18 -0400
Received: from comal.ext.ti.com ([198.47.26.152]:59019 "EHLO comal.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750709AbcECNsQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 May 2016 09:48:16 -0400
Date: Tue, 3 May 2016 08:48:13 -0500
From: Bin Liu <b-liu@ti.com>
To: Yegor Yefremov <yegorslists@googlemail.com>
CC: Maxim Uvarov <muvarov@gmail.com>,
        kernel list <linux-kernel@vger.kernel.org>,
        linux-usb <linux-usb@vger.kernel.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error
Message-ID: <20160503134813.GA690@uda0271908>
Mail-Followup-To: Bin Liu <b-liu@ti.com>,
	Yegor Yefremov <yegorslists@googlemail.com>,
	Maxim Uvarov <muvarov@gmail.com>,
	kernel list <linux-kernel@vger.kernel.org>,
	linux-usb <linux-usb@vger.kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	sergei.shtylyov@cogentembedded.com
References: <1461739918-9583-1-git-send-email-muvarov@gmail.com>
 <20160427154620.GB5604@uda0271908>
 <CAJGZr0JNgYccDdsPLPWGyY3ASnN4PBxfJuhxeEEWk87T0qh2fg@mail.gmail.com>
 <20160427191356.GA16821@uda0271908>
 <20160427212823.GA14645@uda0271908>
 <CAJGZr0JwefevBRxbG_k5jPqf8Bi9ndMMieTcAKfkgCRGcbfjrg@mail.gmail.com>
 <20160428143714.GA7222@uda0271908>
 <CAGm1_ksaa8P1fs03-DSsjvVQu_=cg4yqw7xumb9Gbm+t19O01w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAGm1_ksaa8P1fs03-DSsjvVQu_=cg4yqw7xumb9Gbm+t19O01w@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Tue, May 03, 2016 at 12:03:52PM +0200, Yegor Yefremov wrote:
> On Thu, Apr 28, 2016 at 4:37 PM, Bin Liu <b-liu@ti.com> wrote:
> > Hi,
> >
> > On Thu, Apr 28, 2016 at 09:51:37AM +0300, Maxim Uvarov wrote:
> >
> > [snip]
> >
> >> Hello Bin,
> >>
> >> yes, it also works with that reset and go to finish:
> >>
> >> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> >> index c3d5fc9..8cd98e7 100644
> >> --- a/drivers/usb/musb/musb_host.c
> >> +++ b/drivers/usb/musb/musb_host.c
> >> @@ -1599,6 +1599,10 @@ void musb_host_rx(struct musb *musb, u8 epnum)
> >>                 status = -EPROTO;
> >>                 musb_writeb(epio, MUSB_RXINTERVAL, 0);
> >>
> >> +               rx_csr &= ~MUSB_RXCSR_H_ERROR;
> >> +               musb_writew(epio, MUSB_RXCSR, rx_csr);
> >> +
> >> +               goto finish;
> >>         } else if (rx_csr & MUSB_RXCSR_DATAERROR) {
> >>
> >>                 if (USB_ENDPOINT_XFER_ISOC != qh->type) {
> >>
> >
> > Thanks for testing it.
> 
> Have tested your patch and now both FT4232 and Huawei don't freeze on removal.
> 
> Bin, Max thanks for fixing this issue.
> 
> Tested-by: Yegor Yefremov <yegorslists@googlemail.com>

Thanks for testing.

Can you please test the patch [1] instead? I'd like to use it as the
fix.

Regards,
-Bin.

[1] http://marc.info/?l=linux-usb&m=146222355213935&w=2