From: Matt Fleming <matt@codeblueprint.co.uk>
To: Peter Jones <pjones@redhat.com>
Cc: Wang YanQing <udknight@gmail.com>,
x86@kernel.org, hpa@zytor.com, tglx@linutronix.de,
mingo@redhat.com, dh.herrmann@gmail.com, tomi.valkeinen@ti.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86:sysfb_efi:efifb_set_system: fix miss valid address range in later BARs
Date: Tue, 3 May 2016 16:20:22 +0100 [thread overview]
Message-ID: <20160503152022.GA2839@codeblueprint.co.uk> (raw)
In-Reply-To: <20160502191119.GB10983@redhat.com>
On Mon, 02 May, at 03:11:20PM, Peter Jones wrote:
> On Sun, May 01, 2016 at 12:21:05AM +0800, Wang YanQing wrote:
> > We can't just break out when meet start is equal to zero,
> > this will cause we miss valid address range in later BARs.
> >
> > On the other hand, it isn't enough to test start only
> > for below situation:
> > 0(start) <= lfb_base < end
> >
> > Note: this patch also add a trivial optimization,
> > break out after we find the address range
> > is valid without test later BARs.
> >
> > Signed-off-by: Wang YanQing <udknight@gmail.com>
>
> This looks correct to me:
>
> Reviewed-By: Peter Jones <pjones@redhat.com>
>
> Cc'ing Matt Fleming, since this should probably go through the EFI tree.
Applied, thanks.
prev parent reply other threads:[~2016-05-03 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 16:21 [PATCH v2] x86:sysfb_efi:efifb_set_system: fix miss valid address range in later BARs Wang YanQing
2016-05-02 19:11 ` Peter Jones
2016-05-03 15:20 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503152022.GA2839@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=dh.herrmann@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pjones@redhat.com \
--cc=tglx@linutronix.de \
--cc=tomi.valkeinen@ti.com \
--cc=udknight@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox