From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932883AbcECPU2 (ORCPT ); Tue, 3 May 2016 11:20:28 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:33391 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932593AbcECPUZ (ORCPT ); Tue, 3 May 2016 11:20:25 -0400 Date: Tue, 3 May 2016 16:20:22 +0100 From: Matt Fleming To: Peter Jones Cc: Wang YanQing , x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, dh.herrmann@gmail.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86:sysfb_efi:efifb_set_system: fix miss valid address range in later BARs Message-ID: <20160503152022.GA2839@codeblueprint.co.uk> References: <20160430162105.GA9955@udknight> <20160502191119.GB10983@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160502191119.GB10983@redhat.com> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 May, at 03:11:20PM, Peter Jones wrote: > On Sun, May 01, 2016 at 12:21:05AM +0800, Wang YanQing wrote: > > We can't just break out when meet start is equal to zero, > > this will cause we miss valid address range in later BARs. > > > > On the other hand, it isn't enough to test start only > > for below situation: > > 0(start) <= lfb_base < end > > > > Note: this patch also add a trivial optimization, > > break out after we find the address range > > is valid without test later BARs. > > > > Signed-off-by: Wang YanQing > > This looks correct to me: > > Reviewed-By: Peter Jones > > Cc'ing Matt Fleming, since this should probably go through the EFI tree. Applied, thanks.