From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933901AbcECPa4 (ORCPT ); Tue, 3 May 2016 11:30:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37272 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933338AbcECPax (ORCPT ); Tue, 3 May 2016 11:30:53 -0400 Date: Tue, 3 May 2016 17:30:48 +0200 From: Radim To: Wanpeng Li Cc: Paolo Bonzini , Wincy Van , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] kvm: robustify steal time record Message-ID: <20160503153048.GB27975@potion> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-05-03 03:19+0000, Wanpeng Li: > From: Wanpeng Li > > Guest should only trust data to be valid when version haven't changed > before and after reads of steal time. Besides not changing, it has to > be an even number. Hypervisor may write an odd number to version field > to indicate that an update is in progress. > > kvm_steal_clock() in guest has already done the read side, make write > side in hypervisor more robust by following the above rule. > > Reviewed-by: Wincy Van > Signed-off-by: Wanpeng Li > --- Queued, thanks.