From: Matt Fleming <matt@codeblueprint.co.uk>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
kernel-janitors@vger.kernel.org, Jeremy Kerr <jk@ozlabs.org>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
vaishali.thakkar@oracle.com, saurabh.truth@gmail.com
Subject: Re: [PATCH] efivarfs: merge boolean flag arguments
Date: Tue, 3 May 2016 16:35:20 +0100 [thread overview]
Message-ID: <20160503153520.GB2839@codeblueprint.co.uk> (raw)
In-Reply-To: <1461245069-10221-1-git-send-email-Julia.Lawall@lip6.fr>
On Thu, 21 Apr, at 03:24:29PM, Julia Lawall wrote:
> The parameters atomic and duplicates of efivar_init always have opposite
> values. Drop the parameter atomic, replace the uses of !atomic with
> duplicates, and update the call sites accordingly.
>
> The code using duplicates is slightly reorganized with an else, to avoid
> duplicating the lock code.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> Not tested. I have assumed that the calls to both variable_is_present and
> dup_variable_bug need to be out of the lock.
>
> drivers/firmware/efi/efivars.c | 5 ++---
> drivers/firmware/efi/vars.c | 23 ++++++++++-------------
> fs/efivarfs/super.c | 3 +--
> include/linux/efi.h | 3 +--
> 4 files changed, 14 insertions(+), 20 deletions(-)
Applied. Thanks Julia.
prev parent reply other threads:[~2016-05-03 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 13:24 [PATCH] efivarfs: merge boolean flag arguments Julia Lawall
2016-05-03 15:35 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503153520.GB2839@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=Julia.Lawall@lip6.fr \
--cc=jk@ozlabs.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=saurabh.truth@gmail.com \
--cc=vaishali.thakkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox