From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756247AbcECPf0 (ORCPT ); Tue, 3 May 2016 11:35:26 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37204 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756231AbcECPfX (ORCPT ); Tue, 3 May 2016 11:35:23 -0400 Date: Tue, 3 May 2016 16:35:20 +0100 From: Matt Fleming To: Julia Lawall Cc: Matthew Garrett , kernel-janitors@vger.kernel.org, Jeremy Kerr , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, vaishali.thakkar@oracle.com, saurabh.truth@gmail.com Subject: Re: [PATCH] efivarfs: merge boolean flag arguments Message-ID: <20160503153520.GB2839@codeblueprint.co.uk> References: <1461245069-10221-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461245069-10221-1-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Apr, at 03:24:29PM, Julia Lawall wrote: > The parameters atomic and duplicates of efivar_init always have opposite > values. Drop the parameter atomic, replace the uses of !atomic with > duplicates, and update the call sites accordingly. > > The code using duplicates is slightly reorganized with an else, to avoid > duplicating the lock code. > > Signed-off-by: Julia Lawall > > --- > Not tested. I have assumed that the calls to both variable_is_present and > dup_variable_bug need to be out of the lock. > > drivers/firmware/efi/efivars.c | 5 ++--- > drivers/firmware/efi/vars.c | 23 ++++++++++------------- > fs/efivarfs/super.c | 3 +-- > include/linux/efi.h | 3 +-- > 4 files changed, 14 insertions(+), 20 deletions(-) Applied. Thanks Julia.