From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934159AbcECQAr (ORCPT ); Tue, 3 May 2016 12:00:47 -0400 Received: from mga03.intel.com ([134.134.136.65]:26739 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933338AbcECQAo (ORCPT ); Tue, 3 May 2016 12:00:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,573,1455004800"; d="scan'208";a="797842923" Date: Tue, 3 May 2016 21:36:12 +0530 From: Vinod Koul To: Dan Carpenter Cc: Liam Girdwood , "Subhransu S. Prusty" , Mark Brown , Jaroslav Kysela , Takashi Iwai , Jeeja KP , Sudip Mukherjee , Arnd Bergmann , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Sachin Mokashi , patches.audio@intel.com Subject: Re: [patch] ASoC: hdac_hdmi: Potential NULL deref in hdac_hdmi_get_spk_alloc() Message-ID: <20160503160611.GU2274@localhost> References: <20160503074258.GA9722@mwanda> <20160503095639.GS2274@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160503095639.GS2274@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 03, 2016 at 03:26:39PM +0530, Vinod Koul wrote: > On Tue, May 03, 2016 at 10:42:58AM +0300, Dan Carpenter wrote: > > We intended || here instead of &&. The original code potentially leads > > to a NULL dereference. > > This looks good to me, I will test this and get back Acked-by: Vinod Koul Tested-by: Sachin Mokashi -- ~Vinod