From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934581AbcECTCS (ORCPT ); Tue, 3 May 2016 15:02:18 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:37258 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933595AbcECTCQ (ORCPT ); Tue, 3 May 2016 15:02:16 -0400 Date: Tue, 3 May 2016 20:02:13 +0100 From: Matt Fleming To: Josh Boyer Cc: Josh Triplett , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86/efi-bgrt: Switch all pr_err() to pr_notice() for invalid BGRT Message-ID: <20160503190213.GC2839@codeblueprint.co.uk> References: <1462297624-3003-1-git-send-email-jwboyer@fedoraproject.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462297624-3003-1-git-send-email-jwboyer@fedoraproject.org> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 03 May, at 01:47:04PM, Josh Boyer wrote: > The promise of pretty boot splashes from firmware via BGRT was at > best only that; a promise. The kernel diligently checks to make > sure the BGRT data firmware gives it is valid, and dutifully warns > the user when it isn't. However, it does so via the pr_err log > level which seems unnecessary. The user cannot do anything about > this and there really isn't an error on the part of Linux to > correct. > > This lowers the log level by using pr_notice instead. Users will > no longer have their boot process uglified by the kernel reminding > us that firmware can and often is broken when the 'quiet' kernel > parameter is specified. Ironic, considering BGRT is supposed to > make boot pretty to begin with. > > Signed-off-by: Josh Boyer > --- > > v2: Switch to using pr_notice instead of pr_debug > > arch/x86/platform/efi/efi-bgrt.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > Applied. Thanks everyone!