From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756446AbcECVIY (ORCPT ); Tue, 3 May 2016 17:08:24 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:57759 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755922AbcECVIX (ORCPT ); Tue, 3 May 2016 17:08:23 -0400 X-Sasl-enc: QakuM2Bzx0rGE4bTNO0fMK41HooGkKBQlCg9vPzwZbh2 1462309702 Date: Tue, 3 May 2016 14:08:21 -0700 From: Greg KH To: Patryk Mezydlo Cc: mwelling@ieee.org, linux-kernel@vger.kernel.org, lidza.louina@gmail.com Subject: Re: [PATCH] Staging: dgnc: fix coding style in dgnc_tty.c Message-ID: <20160503210821.GA26753@kroah.com> References: <20160503183727.GA2379@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160503183727.GA2379@debian> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 03, 2016 at 08:37:27PM +0200, Patryk Mezydlo wrote: > Fix checkpatch.pl warning about 'line over 80 characters'. > I just split line with function. > > Signed-off-by: Patryk Mezydlo > --- > drivers/staging/dgnc/dgnc_tty.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c > index 9aa0ba0..b818b0a 100644 > --- a/drivers/staging/dgnc/dgnc_tty.c > +++ b/drivers/staging/dgnc/dgnc_tty.c > @@ -186,7 +186,8 @@ int dgnc_tty_register(struct dgnc_board *brd) > if (IS_ERR(brd->serial_driver)) > return PTR_ERR(brd->serial_driver); > > - snprintf(brd->serial_name, MAXTTYNAMELEN, "tty_dgnc_%d_", brd->boardnum); > + snprintf(brd->serial_name, MAXTTYNAMELEN, > + "tty_dgnc_%d_", brd->boardnum); Why move the string to a new line? It didn't need to be there, did it?