Re: [PATCH 7/8] pci: spread interrupt vectors in pci_alloc_irq_vectors

Thomas Gleixner
2016-04-18T08:31:51Z

On Fri, 15 Apr 2016, Christoph Hellwig wrote:
> Set the affinity_mask before allocating vectors. And for now we also
> need a little hack after allocation, hopefully someone smarter than me
> can move this into the core code.
>
>
> + /* XXX: this should really move into the core IRQ allocation code.. */
> + if (vecs > 1) {
> + for (i = 0; i < vecs; i++)
> + irq_program_affinity(irqs[i]);

No. We don't want to do that at allocation time. The problem here is that we
set the IRQF_NOBALANCING flag for the allocated interrupts and therefor the
affinity is not set from request_irq(). We'll fix it there.

Thanks,

tglx