From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751812AbcEDF4L (ORCPT ); Wed, 4 May 2016 01:56:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38619 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbcEDF4K (ORCPT ); Wed, 4 May 2016 01:56:10 -0400 Date: Tue, 3 May 2016 22:56:09 -0700 From: Greg KH To: Daeseok Youn Cc: lidza.louina@gmail.com, markh@compro.net, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, dan.carpenter@oracle.com Subject: Re: [PATCH] staging: dgnc: Fix a NULL pointer dereference Message-ID: <20160504055609.GA30446@kroah.com> References: <20160504054122.GA11128@certreview.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160504054122.GA11128@certreview.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 04, 2016 at 02:41:22PM +0900, Daeseok Youn wrote: > The error handling for print_drive after calling tty_alloc_driver() > was needed. But there was error handling but too late for this. > Error handling code moved after tty_alloc_driver() call. > > Fixes: 60b3109e5e2d ("staging: dgnc: use tty_alloc_driver instead of kcalloc") > Reported-by: Dan Carpenter > Signed-off-by: Daeseok Youn > --- > drivers/staging/dgnc/dgnc_tty.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Patch doesn't apply at all, does it need something else to be merged first? confused, greg k-h