From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757106AbcEDH2h (ORCPT ); Wed, 4 May 2016 03:28:37 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:33513 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbcEDH2f (ORCPT ); Wed, 4 May 2016 03:28:35 -0400 Date: Wed, 4 May 2016 09:28:34 +0200 From: Johan Hovold To: Konstantin Shkolnyy Cc: johan@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/3] USB: serial: cp210x: Got rid of magic numbers in CRTSCTS flag code. Message-ID: <20160504072834.GA1367@localhost> References: <1462323143-27514-1-git-send-email-konstantin.shkolnyy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462323143-27514-1-git-send-email-konstantin.shkolnyy@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 03, 2016 at 07:52:23PM -0500, Konstantin Shkolnyy wrote: > Replaced magic numbers used in the CRTSCTS flag code with symbolic names > from the chip specification. > > Signed-off-by: Konstantin Shkolnyy This patch does not even compile. Please be more careful when resubmitting. There are at least two compilation errors below. > --- > v4: > Same series of patches, fixed names and defines by feedback. > v3: > Regenerated the patches correctly against the latest usb-next branch. > v2 > Improved CRTSCTS fix by feedback. Dropped get_termios error handling fix. In the future, if you have an aggregate changelog for a series, put it in a cover letter. A cover letter is good to have anyway and should provide a high-level summary of what the series does. Thanks, Johan