From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752956AbcEDNU5 (ORCPT ); Wed, 4 May 2016 09:20:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42769 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbcEDNUz (ORCPT ); Wed, 4 May 2016 09:20:55 -0400 Date: Wed, 4 May 2016 09:20:51 -0400 From: Luiz Capitulino To: Clark Williams Cc: John Kacur , RT , LKML Subject: Re: [PATCH] cyclictest: stop any tracing after hitting a breaktrace threshold Message-ID: <20160504092051.54002514@redhat.com> In-Reply-To: <20160503152839.4543a973@sluggy.hsv.redhat.com> References: <20160503125953.1987bedd@sluggy.hsv.redhat.com> <20160503155644.0aa34c34@redhat.com> <20160503152839.4543a973@sluggy.hsv.redhat.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 04 May 2016 13:20:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 May 2016 15:28:39 -0500 Clark Williams wrote: > The intent is to be able to do something like this: > > trace-cmd start -e all -p function > rteval --duration=12h --cyclictest-breaktrace=150 > trace-cmd extract Ah, ok, I get it now. This makes sense. I think I'd refactor the code opening tracing_on to its own function so that we avoid the duplicate code in setup_tracer(), but in any case: Reviewed-by: Luiz Capitulino