From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752436AbcEDLqK (ORCPT ); Wed, 4 May 2016 07:46:10 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:36766 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbcEDLqI (ORCPT ); Wed, 4 May 2016 07:46:08 -0400 Date: Wed, 4 May 2016 12:46:05 +0100 From: Matt Fleming To: Borislav Petkov Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Ard Biesheuvel , Kweh Hock Leong , "Bryan O'Donoghue" , joeyli Subject: Re: [PATCH] efi/capsule: Make efi_capsule_pending() lockless Message-ID: <20160504114605.GH2839@codeblueprint.co.uk> References: <1462054407-9735-1-git-send-email-matt@codeblueprint.co.uk> <20160503090229.GC27540@pd.tnic> <20160503141201.GW2839@codeblueprint.co.uk> <20160504093031.GA4074@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160504093031.GA4074@pd.tnic> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 04 May, at 11:30:31AM, Borislav Petkov wrote: > > Hmmm, so panic() does bust_spinlocks() and efi_capsule_pending() could > look at oops_in_progress which is set by bust_spinlocks() and that would > probably solve the panic case but maybe the normal reboot case would > still hang... But emergency_restart() is called after bust_spinlocks(0) which can reset oops_in_progress, so can't even use that to solve the panic case.