public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Ray Jui <ray.jui@broadcom.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: Update iProc GPIO bindings
Date: Wed, 4 May 2016 08:20:20 -0500	[thread overview]
Message-ID: <20160504132020.GA21065@rob-hp-laptop> (raw)
In-Reply-To: <1462222308-4869-2-git-send-email-ray.jui@broadcom.com>

On Mon, May 02, 2016 at 01:51:47PM -0700, Ray Jui wrote:
> Update the iProc GPIO binding document to add new compatible strings
> "brcm,iproc-gpio-v2" and "brcm,iproc-gpio-v3" for the 2nd and 3rd
> generation of the iProc GPIO controllers
> 
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> ---
>  Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt b/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt
> index e427792..3a56649 100644
> --- a/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt
> @@ -4,7 +4,16 @@ Required properties:
>  
>  - compatible:
>      Must be "brcm,cygnus-ccm-gpio", "brcm,cygnus-asiu-gpio",
> -    "brcm,cygnus-crmu-gpio" or "brcm,iproc-gpio"
> +    or "brcm,cygnus-crmu-gpio" for Cygnus SoCs
> +
> +    "brcm,iproc-gpio" for the first generation of the GPIO controller that
> +    supports full-featured pinctrl and GPIO functions used in iProc based SoCs
> +
> +    "brcm,iproc-gpio-v2" for the second generation of the GPIO controller that
> +    has the drive strength pinctrl support disabled, e.g., in the iProc NSP SoC
> +
> +    "brcm,iproc-gpio-v3" for the third generation of the GPIO controller that
> +    has the general pinctrl support completely disabled

You can have these for driver matching, but you still need SoC specific 
compatible strings.

Rob

  reply	other threads:[~2016-05-04 13:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-02 20:51 [PATCH v2 0/2] Additional iProc GPIO support Ray Jui
2016-05-02 20:51 ` [PATCH v2 1/2] dt-bindings: Update iProc GPIO bindings Ray Jui
2016-05-04 13:20   ` Rob Herring [this message]
2016-05-04 16:29     ` Ray Jui
2016-05-11 14:06       ` Rob Herring
2016-05-11 15:50         ` Ray Jui
2016-05-02 20:51 ` [PATCH v2 2/2] pinctrl: iproc: Add v2/v3 GPIO support Ray Jui
2016-05-11  9:29 ` [PATCH v2 0/2] Additional iProc " Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160504132020.GA21065@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ray.jui@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox