From: Johan Hovold <johan@kernel.org>
To: Konstantin Shkolnyy <Konstantin.Shkolnyy@silabs.com>
Cc: Johan Hovold <johan@kernel.org>,
Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH v4 2/3] USB: serial: cp210x: Got rid of magic numbers in CRTSCTS flag code.
Date: Wed, 4 May 2016 15:22:02 +0200 [thread overview]
Message-ID: <20160504132202.GI1367@localhost> (raw)
In-Reply-To: <BLUPR0701MB1572B426E22B35207E70FBCE917B0@BLUPR0701MB1572.namprd07.prod.outlook.com>
On Wed, May 04, 2016 at 01:17:26PM +0000, Konstantin Shkolnyy wrote:
> > -----Original Message-----
> > From: Johan Hovold [mailto:jhovold@gmail.com] On Behalf Of Johan Hovold
> > Sent: Wednesday, May 04, 2016 07:55
> > To: Konstantin Shkolnyy
> > Cc: Johan Hovold; Konstantin Shkolnyy; linux-usb@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [EXT] Re: [PATCH v4 2/3] USB: serial: cp210x: Got rid of magic
> > numbers in CRTSCTS flag code.
> >
> > On Wed, May 04, 2016 at 12:46:17PM +0000, Konstantin Shkolnyy wrote:
> > > > -----Original Message----- From: linux-usb-owner@vger.kernel.org
> > > > [mailto:linux-usb- owner@vger.kernel.org] On Behalf Of Johan Hovold
> > > > Sent: Wednesday, May 04, 2016 02:29 To: Konstantin Shkolnyy Cc:
> > > > johan@kernel.org; linux-usb@vger.kernel.org; linux-
> > > > kernel@vger.kernel.org Subject: [EXT] Re: [PATCH v4 2/3] USB:
> > > > serial: cp210x: Got rid of magic numbers in CRTSCTS flag code.
> > > >
> > > > On Tue, May 03, 2016 at 07:52:23PM -0500, Konstantin Shkolnyy wrote:
> > > > > Replaced magic numbers used in the CRTSCTS flag code with symbolic
> > > > names
> > > > > from the chip specification.
> > > > >
> > > > > Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>
> > > >
> > > > This patch does not even compile. Please be more careful when
> > > > resubmitting. There are at least two compilation errors below.
> > >
> > > Sorry about that.
> > >
> > > It's a couple of dumb syntax errors that don't really matter for
> > > change review purpose. Otherwise, do the patches look good?
> >
> > It's worse than that as when the code doesn't even compile it's obvious
> > that it has never been tested. That is just not acceptable, and the code
> > does not deserve review.
>
> Well, I did test the final code. I assumed, perhaps incorrectly, that
> the point of a patch series is that it gets applied or rejected
> entirely, so nobody would run the code in the middle of it.
No, every patch in a series should be correct, and must specifically not
break bisectability by failing to compile.
Johan
prev parent reply other threads:[~2016-05-04 13:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 0:52 [PATCH v4 2/3] USB: serial: cp210x: Got rid of magic numbers in CRTSCTS flag code Konstantin Shkolnyy
2016-05-04 7:28 ` Johan Hovold
2016-05-04 12:46 ` [EXT] " Konstantin Shkolnyy
2016-05-04 12:55 ` Johan Hovold
2016-05-04 13:17 ` Konstantin Shkolnyy
2016-05-04 13:22 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504132202.GI1367@localhost \
--to=johan@kernel.org \
--cc=Konstantin.Shkolnyy@silabs.com \
--cc=konstantin.shkolnyy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox