From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752938AbcEDO7Q (ORCPT ); Wed, 4 May 2016 10:59:16 -0400 Received: from mail.aperture-lab.de ([138.201.29.205]:52113 "EHLO mail.aperture-lab.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750996AbcEDO7P (ORCPT ); Wed, 4 May 2016 10:59:15 -0400 Date: Wed, 4 May 2016 16:59:11 +0200 From: Linus =?utf-8?Q?L=C3=BCssing?= To: Stephen Hemminger Cc: netdev@vger.kernel.org, "David S . Miller" , bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Simon Wunderlich Subject: Re: [PATCH net] bridge: fix igmp / mld query parsing Message-ID: <20160504145911.GA2604@otheros> References: <1462306734-4183-1-git-send-email-linus.luessing@c0d3.blue> <20160503132623.59cf54fb@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160503132623.59cf54fb@xeon-e3> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 03, 2016 at 01:26:23PM -0700, Stephen Hemminger wrote: > On Tue, 3 May 2016 22:18:54 +0200 > Linus Lüssing wrote: > > > diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c > > index 03661d9..7105cdf 100644 > > --- a/net/bridge/br_multicast.c > > +++ b/net/bridge/br_multicast.c > > @@ -1271,6 +1271,7 @@ static int br_ip4_multicast_query(struct net_bridge *br, > > unsigned long max_delay; > > unsigned long now = jiffies; > > __be32 group; > > + int offset = skb_transport_offset(skb); > shouldn't this be unsigned? Yes, should always be unsigned here. Ok, I'm changing that (even though skb_transport_offset() is "static inline int").