From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753041AbcEDQW0 (ORCPT ); Wed, 4 May 2016 12:22:26 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49880 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbcEDQWZ (ORCPT ); Wed, 4 May 2016 12:22:25 -0400 Date: Wed, 4 May 2016 17:22:00 +0100 From: Mark Brown To: Robert Jarzmik Cc: Daniel Mack , Haojian Zhuang , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com Message-ID: <20160504162200.GX6292@sirena.org.uk> References: <1462050939-27940-1-git-send-email-robert.jarzmik@free.fr> <1462050939-27940-3-git-send-email-robert.jarzmik@free.fr> <20160503162938.GT6292@sirena.org.uk> <87twiforl3.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AAkN98o3X3ouhQaz" Content-Disposition: inline In-Reply-To: <87twiforl3.fsf@belgarion.home> X-Cookie: Use in well-ventilated area. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --AAkN98o3X3ouhQaz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 03, 2016 at 09:43:20PM +0200, Robert Jarzmik wrote: > You probably mean the BITCLK clock. > What is a bit pesky about this clock is that it can either be mastered by > digital controller and the codec is a slave, or the other way around. That's a bit surprising - I've never encountered a system that impelemnts this, it may be permitted by the spec but it's always the CODEC. The master clock from the CODEC is often provided by the SoC but I've not seen systems where anything other than the CODEC drives the actual AC'97 bus. > >> +int ac97_digital_controller_register(const struct ac97_controller_ops *ops, > >> + struct device *dev); > >> +int ac97_digital_controller_unregister(const struct device *dev); > > Why "digital"? > I copy-pasted this from Audio Codec '97 Revision 2.3, where in several places > they call the controller a "digital controller". It's not really adding anything though, it's just clumsy wording on their part - it's not like we need to distinguish this from analogue or any other type of AC'97 controllers. > Now if you prefer "ac97_controller" or something like that, that's as you wish, > the name does not matter that much to me ;) Yes. --AAkN98o3X3ouhQaz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXKiGlAAoJECTWi3JdVIfQbD0IAIPYGLrmc7omWG2b8GSc8+4y BGrqqBcZr3Y3jlJtfo2IHi4NNZfXcTCDg4/CFdU2PHVlJ98Lo0bejVLY5kKlWN0o 6/Lj+zSxvNKyCdQVL4yclK2UdD/9Ga9EgdRuTH6lmfukEvmBfVNH4H7aArAEN8uy igmQdsv9SL6CuCffJcRzsQalSwQNRqvi5m7pVK63kAntvkl4in0TrhPgLskjixRB Oq7RBePdny2F7TPxJSyKntoL4PTBHBCeziyVc1uARAl98574+9Z+n4sroChM3jPX aXu1HhpLX9F05wqoMp/3425/rctjZ7cZUvDVzKAiaAQ3xbuvUXNUd9v8sBskv9o= =Bi9D -----END PGP SIGNATURE----- --AAkN98o3X3ouhQaz--