From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755357AbcEDSVb (ORCPT ); Wed, 4 May 2016 14:21:31 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51108 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752124AbcEDSV3 (ORCPT ); Wed, 4 May 2016 14:21:29 -0400 Date: Wed, 4 May 2016 11:21:27 -0700 From: Stephen Boyd To: Viresh Kumar Cc: Rafael Wysocki , Viresh Kumar , Nishanth Menon , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, Marc Gonzalez , linux-kernel@vger.kernel.org Subject: Re: [PATCH] PM / OPP: Remove useless check Message-ID: <20160504182127.GR3492@codeaurora.org> References: <080908c24c189b44442b2fee7be83e760a6dac49.1462367990.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <080908c24c189b44442b2fee7be83e760a6dac49.1462367990.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/04, Viresh Kumar wrote: > Regulators are optional for devices using OPPs and the OPP core > shouldn't be printing any errors for such missing regulators. > > It was fine before the commit 0c717d0f9cb4, but that failed to update > this part of the code to remove an 'always true' check and an extra > unwanted print message. > > Fix that now. > > Fixes: 0c717d0f9cb4 ("PM / OPP: Initialize regulator pointer to an error value") > Reported-by: Marc Gonzalez > Signed-off-by: Viresh Kumar > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project