* [PATCH] PM / OPP: Remove useless check
@ 2016-05-04 13:19 Viresh Kumar
2016-05-04 18:21 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2016-05-04 13:19 UTC (permalink / raw)
To: Rafael Wysocki, Viresh Kumar, Nishanth Menon, Stephen Boyd
Cc: linaro-kernel, linux-pm, Viresh Kumar, Marc Gonzalez,
linux-kernel
Regulators are optional for devices using OPPs and the OPP core
shouldn't be printing any errors for such missing regulators.
It was fine before the commit 0c717d0f9cb4, but that failed to update
this part of the code to remove an 'always true' check and an extra
unwanted print message.
Fix that now.
Fixes: 0c717d0f9cb4 ("PM / OPP: Initialize regulator pointer to an error value")
Reported-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/base/power/opp/core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c
index 433b60092972..d8f4cc22856c 100644
--- a/drivers/base/power/opp/core.c
+++ b/drivers/base/power/opp/core.c
@@ -259,9 +259,6 @@ unsigned long dev_pm_opp_get_max_volt_latency(struct device *dev)
reg = opp_table->regulator;
if (IS_ERR(reg)) {
/* Regulator may not be required for device */
- if (reg)
- dev_err(dev, "%s: Invalid regulator (%ld)\n", __func__,
- PTR_ERR(reg));
rcu_read_unlock();
return 0;
}
--
2.7.1.410.g6faf27b
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PM / OPP: Remove useless check
2016-05-04 13:19 [PATCH] PM / OPP: Remove useless check Viresh Kumar
@ 2016-05-04 18:21 ` Stephen Boyd
2016-05-05 14:00 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2016-05-04 18:21 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael Wysocki, Viresh Kumar, Nishanth Menon, linaro-kernel,
linux-pm, Marc Gonzalez, linux-kernel
On 05/04, Viresh Kumar wrote:
> Regulators are optional for devices using OPPs and the OPP core
> shouldn't be printing any errors for such missing regulators.
>
> It was fine before the commit 0c717d0f9cb4, but that failed to update
> this part of the code to remove an 'always true' check and an extra
> unwanted print message.
>
> Fix that now.
>
> Fixes: 0c717d0f9cb4 ("PM / OPP: Initialize regulator pointer to an error value")
> Reported-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PM / OPP: Remove useless check
2016-05-04 18:21 ` Stephen Boyd
@ 2016-05-05 14:00 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2016-05-05 14:00 UTC (permalink / raw)
To: Stephen Boyd, Viresh Kumar
Cc: Viresh Kumar, Nishanth Menon, linaro-kernel, linux-pm,
Marc Gonzalez, linux-kernel
On Wednesday, May 04, 2016 11:21:27 AM Stephen Boyd wrote:
> On 05/04, Viresh Kumar wrote:
> > Regulators are optional for devices using OPPs and the OPP core
> > shouldn't be printing any errors for such missing regulators.
> >
> > It was fine before the commit 0c717d0f9cb4, but that failed to update
> > this part of the code to remove an 'always true' check and an extra
> > unwanted print message.
> >
> > Fix that now.
> >
> > Fixes: 0c717d0f9cb4 ("PM / OPP: Initialize regulator pointer to an error value")
> > Reported-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-05 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-04 13:19 [PATCH] PM / OPP: Remove useless check Viresh Kumar
2016-05-04 18:21 ` Stephen Boyd
2016-05-05 14:00 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox