From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755404AbcEDSeB (ORCPT ); Wed, 4 May 2016 14:34:01 -0400 Received: from down.free-electrons.com ([37.187.137.238]:36873 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751713AbcEDSd7 (ORCPT ); Wed, 4 May 2016 14:33:59 -0400 Date: Wed, 4 May 2016 20:33:47 +0200 From: Maxime Ripard To: Arnd Bergmann Cc: David Airlie , Chen-Yu Tsai , Dave Airlie , Boris Brezillon , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/sun4i: add COMMON_CLK dependency Message-ID: <20160504183347.GE17159@lukather> References: <1462186805-2211918-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DGEpNJVZyRrKVy7j" Content-Disposition: inline In-Reply-To: <1462186805-2211918-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --DGEpNJVZyRrKVy7j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, May 02, 2016 at 12:59:48PM +0200, Arnd Bergmann wrote: > The sun4i drm driver uses the clk-provider interfaces, which are not avai= lable > when CONFIG_COMMON_CLK is disabled: >=20 > drivers/gpu/drm/sun4i/sun4i_dotclock.c:19:16: error: field 'hw' has incom= plete type > struct clk_hw hw; > In file included from ../include/asm-generic/bug.h:13:0, > from ../arch/arm/include/asm/bug.h:59, > from ../include/linux/bug.h:4, > from ../include/linux/io.h:23, > from ../include/linux/clk-provider.h:14, > from ../drivers/gpu/drm/sun4i/sun4i_dotclock.c:13: > drivers/gpu/drm/sun4i/sun4i_dotclock.c: In function 'hw_to_dclk': > include/linux/kernel.h:831:48: error: initialization from incompatible po= inter type [-Werror=3Dincompatible-pointer-types] > ... >=20 > This adds a Kconfig dependency to prevent the driver from being enabled > in this case. >=20 > Signed-off-by: Arnd Bergmann > Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support") Applied, thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --DGEpNJVZyRrKVy7j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXKkCLAAoJEBx+YmzsjxAgfesP/j+72ftYTdxs4lElmxf09iPx rec2aD/At0/HD+r1z+g7d6zK9Fp40msmR9/TA8/Lb4TKRkMiJ14SHPBg90fcRhoY NwbB14JrGgUTEG7Zv/gjj0AY+GMiTReUZNcLPyhw2Eq95wVtgO0QyZ1zj4Ba7+M2 43F34UBaYIBW/PR6PjqegEwiwy77vYWoKTB0sKijJcMQRfIb4FuOHC+urMAA0EWn xPkjEXQypFH63DUt2aCPPnYUp2+/g5NKkOWc02n+xUgVRwG055LWLqTBaXYHwvWh bOY80SsVzorHCck86XPpK/DcR7hjyL8LZOEsy9A+x8mXpoBEJShmKlY8HzCK/3RL J0H2Q6qwkd4LKIebYAPh/SQQRXlER8992wb1h4y5xjst8VLqNlKC7cZ72TpJ5TWW G3B0+uRJ+6t+uvZAOjyXMMrFVWmL/dF92VfvWvatRVCLzFBx+3d7PXE1ZJm02bhV WFK6VU3VkGl95ZY5oohcecWkxj61d8BDccNNc4Cb1+RpS5AZDpwOeLJph+bIzjL7 fnASfz/sooqwO3QTnjlPnmDFh5JHm7Gt6JlcaEFYkycsN9Ik4BcRpq1KGHk9+eJ0 vw5AgytltBzqe5ax2y5eS1TI5/Lnoxb9y9AdZciLyFTgaLFbyNocLU+vIZfV8aJX pr9PFtqnZBPs17Pvf/V+ =zObB -----END PGP SIGNATURE----- --DGEpNJVZyRrKVy7j--