From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755497AbcEDSec (ORCPT ); Wed, 4 May 2016 14:34:32 -0400 Received: from down.free-electrons.com ([37.187.137.238]:36906 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752454AbcEDSe3 (ORCPT ); Wed, 4 May 2016 14:34:29 -0400 Date: Wed, 4 May 2016 20:34:17 +0200 From: Maxime Ripard To: Arnd Bergmann Cc: David Airlie , Chen-Yu Tsai , Boris Brezillon , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: sun4i: print DMA address correctly Message-ID: <20160504183417.GF17159@lukather> References: <1462289020-774976-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zZlcsJOVyAcDN4NF" Content-Disposition: inline In-Reply-To: <1462289020-774976-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zZlcsJOVyAcDN4NF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 03, 2016 at 05:23:28PM +0200, Arnd Bergmann wrote: > The newly added sun4i drm driver prints a dma address using the %x > format string, which cannot work when dma_addr_t is 64 bit, > and gcc warns about this configuration: >=20 > drm/sun4i/sun4i_backend.c: In function 'sun4i_backend_update_layer_buffer= ': > drm/sun4i/sun4i_backend.c:193:84: error: format '%x' expects argument of = type 'unsigned int', but argument 3 has type 'dma_addr_t {aka long long uns= igned int}' [-Werror=3Dformat=3D] > DRM_DEBUG_DRIVER("Using GEM @ 0x%x\n", gem->paddr); > drm/sun4i/sun4i_backend.c:201:84: error: format '%x' expects argument of = type 'unsigned int', but argument 3 has type 'dma_addr_t {aka long long uns= igned int}' [-Werror=3Dformat=3D] > DRM_DEBUG_DRIVER("Setting buffer address to 0x%x\n", paddr); >=20 > This changes the code to use the explicit %pad format string, which > always prints the right length. >=20 > Signed-off-by: Arnd Bergmann Applied, thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --zZlcsJOVyAcDN4NF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXKkCpAAoJEBx+YmzsjxAgW60P/3Qpw8k4g1iVVpupQUWBC3Tu M5LboRCOSxxrX9Iv0DVouwb+TkA41BpQuqtn72Mlrs0naLxoqfPylZIGokCUTZHY BhekDisx6mcs+GtdYFxRe4/CwLgF5kCY94xyxTFvV84uHadOEarsYDeeCjtsoQX3 DVbm0R6o0dtZkJ2l0i3iwnPMw4yQ8E/kndQ8vdBhXffxcSXlQopsiCC+ihJ9eJxV DHyzijuZu3EKZHRmO+tD7tXT9yrqtuvx3ybT1pWMKXbjHQnZgutUM5guD/TqnDWg cxtm2GqUh/Hoc2df1I5BVFl+ynlNzCoEx4f8fjzFj7qNfi+Fj96Z51wjkYIBHbaD kMQL+1Y+CMessuf4zg+HPmkPeVQlIPwbpgU1PgbvH/KrTrni6GaeeeK/MFUzzLAs V2B9JeGH527APJBAMwWpiz6InUnHJPUPTR0kF99kY3RT6oq2BkrWvDuXkIXwSXuL BH7NfIcqUc725MEmTaHJJP4Qor3sMc7YllSh+qsQb40JSPx0du4oLNKye0e3vMYf hX/niZ3tkO1F2dLfJVwgGLkhBLt56cZaddeLs78HhflL3hmfGV9LxREAsp1Q3HWx kswhEFfvW1PWum8rXeVIG5LEI2Wx64864fQHnBdhT8Z9ywxB8jN4EEhNRY5UbNoe L4lqQKhtt6YZaKLhI0vb =bWmA -----END PGP SIGNATURE----- --zZlcsJOVyAcDN4NF--