From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753506AbcEDT3F (ORCPT ); Wed, 4 May 2016 15:29:05 -0400 Received: from mout.gmx.net ([212.227.17.20]:62249 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752610AbcEDT3D (ORCPT ); Wed, 4 May 2016 15:29:03 -0400 Date: Wed, 4 May 2016 21:28:45 +0200 From: Stefan Lippers-Hollmann To: Linus Torvalds Cc: Mauro Carvalho Chehab , Linux Media Mailing List , Linux Kernel Mailing List Subject: Re: [GIT PULL for v4.6-rc1] media updates Message-ID: <20160504212845.21dab7c8@mir> In-Reply-To: References: <20160315080552.3cc5d146@recife.lan> <20160503233859.0f6506fa@mir> <20160504063902.0af2f4d7@mir> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_//D.fC5zdrxpwRT1/mvrnY+K"; protocol="application/pgp-signature" X-Provags-ID: V03:K0:6NvBcoGemHRyfJSRdLl0nIOeN2I73EdUK+kJGbvqnl0NPM/Wn66 lPk4yGdWLqMKzK6juHjAtTeSjW61AG2BFwghJIdqkQCzsMvNMqlEzzHiySlqopePLrc4Bfm ykf7Ww9o16vgnTIYlxUOT+C71aWDnb8W0nhGB82c/sdBEsIFvKrAxvlYDkwN1wE3IVaLJPF Ei1OiYrBoLuaxAjNTn08g== X-UI-Out-Filterresults: notjunk:1;V01:K0:d7P1QpgmK6Y=:eHQGT8BCY9FldQ2wQvg0Z3 alCsEtuTbQT9V029ijoWAsSljoa5Fes3FhYBRrA6hYElFVg+K0z//A9lc94cvcjXT82FIfLP2 G3q+3UWj4+DHUHZsbvfMmjSa6LXecjVteh6aQgIm/krbANYlmLLtKWiIFT1BcZ8NFBNT+PoLM aXo9hD0ctxuJYgALpgKyiQFLbYWppHAZWJdgnq3ArLDTOPlC4WWmPFGi84iDtZSgcwbog6WbJ wp5mZbLjOxILjbbraWoafROwwNEDq02VIi4MNUdQwoy/YJL1i6QEUntQ+kdfAOQJrhM7LzuJP dVOrm0HOmyLs+SllkPdU1D+MzNCF5X9AYG1Trq3I9Txxkyp2YOE4IMlnp7yYKDTIk1o5c+qRo eeJe6vms5COccVAqxEH2DEZks4R1m6sT24I0YxULuP0WzRAVhIVzfZS7sBk5+YPBafdU2hsi3 ifid1DJDnFbZJ8VVcbUEKdPB8OcdoRoz93azMso3vQpBqsKPMfER04yePYf6CGRRe/54aDnYX DzZMVprlXwo8n3MGeYEf+mo6TmT7edC1Cfy5SsINMurU1h47SSafvFfhZH6FwJcJOURPpKIUb urvga9F7wIIOVOPDa1zPDniEFeKE3U/HU70Dt+k6yGJpFQbRfPl4yDFBi/8rpjMxL1688exci RhWKmpOS1Ud+Q1VrKsiM1flqK+XfX+U69iJRh3g/4gl+zRgJ8ueTFRmx6dsO2kg7kjvQxSKYj Pkm31vusbiPOHWIgZJmOZ4lRl3XI8EHEtaQp3JRxHEL19dcw1c4i8WjLRyg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_//D.fC5zdrxpwRT1/mvrnY+K Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi On 2016-05-04, Linus Torvalds wrote: > On Tue, May 3, 2016 at 9:39 PM, Stefan Lippers-Hollmann wr= ote: > > > > Just as a cross-check, this (incomplete, but au0828, cx231xx and em28xx > > aren't needed/ loaded on my system) crude revert avoids the problem for > > me on v4.6-rc6-113-g83858a7. =20 >=20 > Hmm. >=20 > That just open-codes __media_device_usb_init(). >=20 > The main difference seems to be that __media_device_usb_init() ends up > having that >=20 > #ifdef CONFIG_USB > #endif >=20 > around it. >=20 > I think that is bogus. >=20 > What happens if you replace that #ifdef CONFIG_USB in > __media_device_usb_init() with >=20 > #if CONFIG_USB || (MODULE && CONFIG_USB_MODULE) [...] that throws drivers/media/media-device.c: In function '__media_device_usb_init': drivers/media/media-device.c:878:5: warning: "CONFIG_USB" is not defined [-= Wundef] #if CONFIG_USB || (MODULE && CONFIG_USB_MODULE) ^ however, taking arch/arm/mach-omap1/include/mach/usb.h as example,=20 changing it to=20 --- a/drivers/media/media-device.c +++ b/drivers/media/media-device.c @@ -875,7 +875,7 @@ void __media_device_usb_init(struct medi const char *board_name, const char *driver_name) { -#ifdef CONFIG_USB +#if defined(CONFIG_USB) || defined(CONFIG_USB_MODULE) mdev->dev =3D &udev->dev; =20 if (driver_name) indeed fixes the problem for me Thanks a lot! Regards Stefan Lippers-Hollmann --Sig_//D.fC5zdrxpwRT1/mvrnY+K Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXKk1tAAoJEL/gLWWx0ULtYs8P/0c/OtHC22oIJzs8bEoQSZiG nsnlkJZr8SVlYg2qOtPmvaZC8ajYuGQOH0UGMIADZ+A30Vs/wN092cN/93/sO/O+ v1W3ExIy1Rzwj7naZXPTC4EUlI+vCPjqHWnlCHNoTgqC/xnAFwr42aON6HyGZ94k nxYFxJ76WyfnutEA48rYFDXG46njN01RJXQV4iYfhUL6aMNEGffBncyp/E2NHVV+ luUiCLFFg5R49bzh9YOk4KbrXtdaJm2zRFwPukN+oZ05nMvgt3FIohaML0ZoCHQ2 9HuICcFV6wwmMuPMr3d/NF8OreRAucxu5UMcyQlx0jRRuWHJh1pkQWt9CaAhEQUf nJRuSaa8cgzcJGrtxVm8SafGfPdJ0eDjpcg7WDWvEEqH344emIiHXTmd8stBChvE aH462t300y8zXvNTCPDMcloI9kOExKJOJXGTjpS6TMs60RT6EB5ofkzLZvfzWlrq g3YLas5me0MYxs5cb6uA+aUitWADq2XHGKxj7Fn6Ae8Cua19xpLe2BRQPQlg97wm OvaKPh97LGnuLxb36jKgnUfK9woUmPB1FiiCW28srEm84MaZaNK5knJ9053lv258 XNsrFXal+sWOXhlP8xMrwuzGNoKXU9FJht0tQnB2Ep0WmS7x3Fi0ZHNMbycrJgOg O4um+d0uYKPprW0WRgA6 =YlDY -----END PGP SIGNATURE----- --Sig_//D.fC5zdrxpwRT1/mvrnY+K--