From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755447AbcEEBI7 (ORCPT ); Wed, 4 May 2016 21:08:59 -0400 Received: from imap.thunk.org ([74.207.234.97]:48014 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752822AbcEEBI6 (ORCPT ); Wed, 4 May 2016 21:08:58 -0400 Date: Wed, 4 May 2016 21:08:53 -0400 From: "Theodore Ts'o" To: Eric Biggers Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org Subject: Re: [PATCH] random: properly align get_random_int_hash Message-ID: <20160505010853.GA10776@thunk.org> Mail-Followup-To: Theodore Ts'o , Eric Biggers , linux-kernel@vger.kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org References: <1459473085-10724-1-git-send-email-ebiggers3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459473085-10724-1-git-send-email-ebiggers3@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 31, 2016 at 08:11:25PM -0500, Eric Biggers wrote: > get_random_long() reads from the get_random_int_hash array using an > unsigned long pointer. For this code to be guaranteed correct on all > architectures, the array must be aligned to an unsigned long boundary. > > Signed-off-by: Eric Biggers Thanks, applied. - Ted