From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755589AbcEEBKT (ORCPT ); Wed, 4 May 2016 21:10:19 -0400 Received: from imap.thunk.org ([74.207.234.97]:48036 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755297AbcEEBKR (ORCPT ); Wed, 4 May 2016 21:10:17 -0400 Date: Wed, 4 May 2016 21:10:07 -0400 From: "Theodore Ts'o" To: Stephan Mueller Cc: Linux Kernel Developers List , herbert@gondor.apana.org.au, andi@firstfloor.org, sandyinchina@gmail.com, cryptography@lakedaemon.net, jsd@av8n.com, hpa@zytor.com, linux-crypto@vger.kernel.org Subject: Re: [PATCH 1/4] random: replace non-blocking pool with a Chacha20-based CRNG Message-ID: <20160505011007.GB10776@thunk.org> Mail-Followup-To: Theodore Ts'o , Stephan Mueller , Linux Kernel Developers List , herbert@gondor.apana.org.au, andi@firstfloor.org, sandyinchina@gmail.com, cryptography@lakedaemon.net, jsd@av8n.com, hpa@zytor.com, linux-crypto@vger.kernel.org References: <1462389951-29439-1-git-send-email-tytso@mit.edu> <1462389951-29439-2-git-send-email-tytso@mit.edu> <2563613.fjdkC65vSW@myon.chronox.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2563613.fjdkC65vSW@myon.chronox.de> User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 04, 2016 at 10:28:24PM +0200, Stephan Mueller wrote: > > +out: > > + spin_unlock_irqrestore(&primary_crng.lock, flags); > > + return ret; > > Where did you add the memzero_explict of tmp? Oops, sorry, somehow that change got lost in the patch updates. Fixed now. - Ted