From: Ingo Molnar <mingo@kernel.org>
To: Dave Hansen <dave@sr71.net>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
luto@amacapital.net, torvalds@linux-foundation.org,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v3] x86/mm/mpx: Work around MPX erratum SKD046
Date: Thu, 5 May 2016 09:26:23 +0200 [thread overview]
Message-ID: <20160505072623.GB22559@gmail.com> (raw)
In-Reply-To: <20160505070103.GA22559@gmail.com>
* Ingo Molnar <mingo@kernel.org> wrote:
> > -#if defined(CONFIG_CPU_SUP_INTEL) && defined(CONFIG_X86_32)
> > +#if defined(CONFIG_CPU_SUP_INTEL)
> > +void check_mpx_erratum(struct cpuinfo_x86 *c);
> > +#else
> > +static inline void check_mpx_erratum(struct cpuinfo_x86 *c) {}
> > +#if defined(CONFIG_X86_32)
> > int ppro_with_ram_bug(void);
> > #else
> > static inline int ppro_with_ram_bug(void) { return 0; }
> > -#endif
> > +#endif /* CONFIG_X86_32 */
> > +#endif /* CONFIG_CPU_SUP_INTEL */
Sigh. So this broke the ppro_with_ram_bug() definition, because in the new code
you put it into the wrong branch, breaking the build ...
I've dropped this for now, please fix and test the v3 version of the patch I sent
and re-send.
Thanks,
Ingo
next prev parent reply other threads:[~2016-05-05 7:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 20:53 [PATCH] [v2] x86, mpx: Workaround for MPX erratum Dave Hansen
2016-05-05 7:01 ` [PATCH v3] x86/mm/mpx: Work around MPX erratum SKD046 Ingo Molnar
2016-05-05 7:26 ` Ingo Molnar [this message]
2016-05-05 17:03 ` Dave Hansen
-- strict thread matches above, loose matches on Subject: below --
2016-05-11 21:16 [PATCH] [v3] " Dave Hansen
2016-05-12 6:50 ` Ingo Molnar
2016-05-12 7:16 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160505072623.GB22559@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=dave@sr71.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox