From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756059AbcEEH0a (ORCPT ); Thu, 5 May 2016 03:26:30 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35252 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751617AbcEEH03 (ORCPT ); Thu, 5 May 2016 03:26:29 -0400 Date: Thu, 5 May 2016 09:26:23 +0200 From: Ingo Molnar To: Dave Hansen Cc: linux-kernel@vger.kernel.org, x86@kernel.org, luto@amacapital.net, torvalds@linux-foundation.org, Thomas Gleixner , "H. Peter Anvin" , Borislav Petkov Subject: Re: [PATCH v3] x86/mm/mpx: Work around MPX erratum SKD046 Message-ID: <20160505072623.GB22559@gmail.com> References: <20160504205359.19DB7812@viggo.jf.intel.com> <20160505070103.GA22559@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160505070103.GA22559@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ingo Molnar wrote: > > -#if defined(CONFIG_CPU_SUP_INTEL) && defined(CONFIG_X86_32) > > +#if defined(CONFIG_CPU_SUP_INTEL) > > +void check_mpx_erratum(struct cpuinfo_x86 *c); > > +#else > > +static inline void check_mpx_erratum(struct cpuinfo_x86 *c) {} > > +#if defined(CONFIG_X86_32) > > int ppro_with_ram_bug(void); > > #else > > static inline int ppro_with_ram_bug(void) { return 0; } > > -#endif > > +#endif /* CONFIG_X86_32 */ > > +#endif /* CONFIG_CPU_SUP_INTEL */ Sigh. So this broke the ppro_with_ram_bug() definition, because in the new code you put it into the wrong branch, breaking the build ... I've dropped this for now, please fix and test the v3 version of the patch I sent and re-send. Thanks, Ingo