From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756375AbcEEIWy (ORCPT ); Thu, 5 May 2016 04:22:54 -0400 Received: from mail-by2on0054.outbound.protection.outlook.com ([207.46.100.54]:22050 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753216AbcEEIWu (ORCPT ); Thu, 5 May 2016 04:22:50 -0400 Authentication-Results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=caviumnetworks.com; Date: Thu, 5 May 2016 11:22:37 +0300 From: Yury Norov To: "Zhangjian (Bamvor)" CC: Arnd Bergmann , Catalin Marinas , , , , , , , , , , , , , , , Philipp Tomsich , , , Hanjun Guo Subject: Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal return Message-ID: <20160505082237.GA32190@yury-N73SV> References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> <1554541.oDP7Ro5zB2@wuerfel> <20160503090045.GB10733@e104818-lin.cambridge.arm.com> <3846428.6xx69KGEja@wuerfel> <57288660.9030607@huawei.com> <57289C75.50904@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <57289C75.50904@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [87.193.135.50] X-ClientProxiedBy: AM2PR02CA0040.eurprd02.prod.outlook.com (10.160.28.178) To SN1PR07MB2237.namprd07.prod.outlook.com (10.164.47.143) X-MS-Office365-Filtering-Correlation-Id: 16474b08-a0ef-44d9-4f63-08d374be70b1 X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2237;2:PhrgTjWTIiOlWsRYbmVC4AJ20IMp/2aISVGmvvCFkEUtt7fR+yrlaoplZ3cfdEE6WwPtjLmj7bEaroRUxheg5C94zSRIi36qsuDsEGdXKR2ygWqTgWDy9nJooAdJEk0XK0hPzjU1PFEcj13oiD6EKQ/8fvgOR8XtyB2tAhf+7EKH+3NeJiCxVBQwpPVziA2d;3:54yINe3bVCVx0IABEWtz+qb/EzKiYq/txCruaailRYjUaNy2fOA9xoxbxY/zvLbQ1IQh8UzKkusj2nH+BUFOqzLk+U3A9MNaGeZRAZp65fNYIqrfEwURZGSlSQra/XK1;25:wTgi3wd3jUJQTOrsT1ji8WxlKod2SHb2/eqkX6SCjuPqlxvuiswV5z9YaxL4mLahAQ5ljQWCbTSikmReHXUfUHwhTzV+QNWw+ey97f9w841CLOjfWpRTHtgvwF9uU76t6DbqkUQjipN39DqdvPtnw8sbO0LbcNQu3NH5PLUPgDUa/xuyCV7mSMHjP/lObFRxaYKDMYlX6qnhdLujxlUJqCNRI/NUtuRbN5jv/UK/knrqODVAZhB9/Uj2/we0/fPkYPssB3dIjG0yMYScTsmMbEXVt/iDUFzR0R3mfcUvaGYq2m4yLK/gSC+QkSll0X08KGyKkvPI82/GqujK+wLseoyRIwldTPSw2pVm9+SH68Xf8D9v+TnI73Hd/alqW8UWEYbcYVkgRA5IqkdlGcGEWNVxPiURzi05k2pwZb3mBveH41ix7ln/rqfeFOzBcqte X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2237; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2237;20:+8/TCp3KX8xxlH46Y5aqfjyfbnITwxQpOoahcrHxz/KHEPwvPW5EBMrbNKi2/BC0N/nKFJs0MC5+JVgoGbbsV58iYEEOsNkjMaS3Mg8JyHFdhUCciPChC2szoXJlmbFNLkBrbopfOw/2MiemDap4yfGZXuJQwRl7iXb4hCUSWs9howCH1m1ba19PhMvEBZS94Fj/02Hp7iSKf8en3SXC/KzAQOMd4j+ba15WhhDqNbBjYBFD2MCUBBB7q1mgYr5SwKIA+aqCeBgo5IHWg+F46fymkaAeJB6qfRP/v5LSadLDhWZpq2UvFS3OqZbgPbBENJzoUQvUtBi0L3yzV4aB1fuyYRe2Y4L1sm7tIE8Zdys1qogx1Vlh1AKYLbV2FfPzD7kJvMiLxW075DgmSZXPlLateN9iQReLEeCnDSxr9Xh9rFa+bk44u8xAH7mzbpANFi88Tne3J6pmeRnsQ1xjam1nExOHEk7iMpdhx2m/qxovReHRt/0HcE/i66h57DZ0rEeUZI7bbSJpQf6ixCxoL6GBUI4KK1z2KBl9PiEp8aWe7/Xp5e1XtQul2rDxMzVTadvdE0776/LwZD0AETsiM3a7ISAynf3jClSH+DrvY8Q= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521098)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:SN1PR07MB2237;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2237; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2237;4:/H7Ddr+Ce4MN++lS4FQHfrrrDGeKwnULGHhH7emNHx/NV/3gYV0OzI9OpaaWl+BothA1gsr9lmiFg88FxgNjSo6XqONcu0jX61/LITM+H3IWZ3Ee3Evjf97b2dN4nNtjmAG9rbm5T9dKaA4jyng8+TnHc+eCxtk4vkxphVJi9n6jRZ2sCy85VzKOcyCGeyqwzq4ilBoUN3jZkmm74Dx5Sf07lH2fIeKxDfLYhh0xur8lDeWlEU3b+doeDT5mHzCtN87bsLvrBJLJL+HYt4q2xI2lJjbVNdiWL4Gj+aUTRdlynyagJH1j6TyefM/wN5ONJqvMGGay+mTbC9JOp6uISy6/mwxL+SIMNfwjcuPxcouGTgThFknm5vfqKMiAPcNqsRl0i0EG637UCX47akTRIA== X-Forefront-PRVS: 0933E9FD8D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(24454002)(83506001)(42186005)(66066001)(47776003)(92566002)(77096005)(4326007)(586003)(189998001)(97756001)(2906002)(6116002)(33716001)(81166005)(23726003)(1076002)(9686002)(3846002)(5004730100002)(54356999)(76176999)(50986999)(50466002)(93886004)(46406003)(5008740100001)(2950100001)(76506005)(4001350100001)(33656002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR07MB2237;H:localhost;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2237;23:rNaQ2YWRIX5CJcJjmgod+B5BD/LLah9/jUIpDELq5O/uxcDgm2amyn0sv8k81gMs35TCuyn1unl6ATRK5jCyxtOC/HVJhEcf6KaPDXdKiAboS9wTbKhYk9uutRjXapHxQDcrZFYpALMgYZNWz5hgVswOyOXe+VPrRUNBQz1yUDdSYyn9jpRiLI7Yr4d82B066nHURalIwrY+w8RI5d0BzJh+C8brL+tA/B8y7MRibi65K0IunbLyg2DgSiF/RC7N4orGKf6UKom8Xt6Ta4FzhpbMtZ0JWjFkNYIfGwiDkNEl4xQcEWWsT0TO6Rj155rnMBDcGRCVcicJlY/A9U4rTVLjP5DZjtT0A6QTMi8Bdvr7kUkYUbX0HIXq2y+vHTfy4NfChkiTtvmqWMGhp6CgYv8nLWzMj/xglQ+hGufSfxVeToTbTijaVF7ubQvYyU9QpMMxFpwZ93KaMzKORqW8nfVlN4IQd9YEjsG1lwn05dRcm5i8AuzF7Nw/DkBdJ7CuFRFN3g7PkC3SgsEuYcqmKqj7yH1mQ8lB6yKfOicWIb4d4ux/ALPCayptvgZgvZLmkDnJowoz2qPLy8G2tHBXwXNzUjV1PKsJr6x35NquV1Qr3dIUG/UEy5ctjwtA1kKseeBONMlnw7fLkTyI/jdOnHWJLq3q06t/M0lhvCo+NRnDbmL0QQMq+Mif0dZZBIG5j+JNpgcZlM48IeKsKhPB+Zqlv4lBvZb2MHQavJT+6C3RsCfr/u0lVQdjiwjT9tucl2T/Jme0se8B/KGYlDmzNnSNCVmBKy3oM8CrKjgnytUitLpBNg5S83u+j+9uH9F5tVr62v6vPMJ5HXNtOuB0RlXLwmeA7hGv/F1vFEuhrdBeFUx5HGGeLzO0le4nZmU/QcEsmWEjF9S7H7PVTb0xs+NutOEug/PTqbU7e3jHwbg= X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2237;5:x7bJFqwqU34wWKTtV7jWCq22cQBkPnvZVnJvlQID9db27PuOZHYyzbni4pfg6aW8xCg5+QHvSmhEgZbLXJAa6smTlYeRG/S7SooIzehNdrr4nwjpJX0hJAB2zyPj1FFR0mgyzDFEcjUgqJ5oRgZ55g==;24:j8nRuIKw1iwhp4/cP/WT4NSxaEFSaZjKPMgQDxLHzLOvBc1NrSTzJVYeP4h2CdLD2AIsAb3gOkobV3ItzU1bcw3ZL7tIHbzi1WC/yogKfqo=;7:e75XdrixXlrHgcIyEVZr2sHhNiEt13LFfWmZBvr64JrJRlH2dr18/F6o5885jcd5ZCq8bZzK+5PkLDpnvRGI8kGSJ/zQdHE76s5mkYK9ghSseavxbQ//x4RQe4WjMPQ7zZYmEXXWQWhIae6LvtFD2xhqTkI3ING8kQLJmsOaJYc4nNGznhAzq1FlcB/8C/pU SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2016 08:22:46.8585 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB2237 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 03, 2016 at 08:41:25PM +0800, Zhangjian (Bamvor) wrote: [...] > After apply this patch with my small testcase, the vsyscall of gettimeofday in > ilp32 works in both big endian and small endian. In this patch, I use the > different register and offset for ilp32 and lp64. Actually, the > COMPAT_TVAL_TV_SEC is same as TVAL_TV_SEC(so as to COMPAT_TSPEC_TV_SEC and > TSPEC_TV_SEC). I add it to keep the logic clear. I also change the version > of vdso to 4.6. It should change to 2.6.39 if glibc is not update. > > diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c > index 574081f..c8e32eb 100644 > --- a/arch/arm64/kernel/asm-offsets.c > +++ b/arch/arm64/kernel/asm-offsets.c > @@ -101,6 +101,11 @@ int main(void) > DEFINE(TSPEC_TV_SEC, offsetof(struct timespec, tv_sec)); > DEFINE(TSPEC_TV_NSEC, offsetof(struct timespec, tv_nsec)); > BLANK(); > + DEFINE(COMPAT_TVAL_TV_SEC, offsetof(struct compat_timeval, tv_sec)); > + DEFINE(COMPAT_TVAL_TV_USEC, offsetof(struct compat_timeval, tv_usec)); > + DEFINE(COMPAT_TSPEC_TV_SEC, offsetof(struct compat_timespec, tv_sec)); > + DEFINE(COMPAT_TSPEC_TV_NSEC, offsetof(struct compat_timespec, tv_nsec)); > + BLANK(); Hi Bamvor, We just found this lines break build if ILP32 is disabled. I think we need to wrap them with #ifdef CONFIG_ARM64_ILP32 Yury