From: Johan Hovold <johan@kernel.org>
To: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>
Cc: johan@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/3] USB: serial: cp210x: Bugfixes and cleanup in CRTSCTS flag code
Date: Thu, 5 May 2016 12:00:10 +0200 [thread overview]
Message-ID: <20160505100010.GM1367@localhost> (raw)
In-Reply-To: <1462398998-419-1-git-send-email-konstantin.shkolnyy@gmail.com>
On Wed, May 04, 2016 at 04:56:38PM -0500, Konstantin Shkolnyy wrote:
> This patch series fixes bugs and replaces magic numbers with symbolic
> names in CRTSCTS flag code.
>
> v5:
> Fixed 2 compile errors in PATCH 2/3, otherwise no change.
> v4:
> Same series of patches, fixed names and defines by feedback.
> v3:
> Regenerated the patches correctly against the latest usb-next branch.
> v2
> Improved CRTSCTS fix by feedback. Dropped get_termios error handling fix.
>
> Konstantin Shkolnyy (3):
> USB: serial: cp210x: Fixed RTS mode setting by the CRTSCTS flag.
> USB: serial: cp210x: Got rid of magic numbers in CRTSCTS flag code.
> USB: serial: cp210x: Cleaned up CRTSCTS flag code.
>
> drivers/usb/serial/cp210x.c | 102 ++++++++++++++++++++++++++++++++------------
> 1 file changed, 74 insertions(+), 28 deletions(-)
Thanks for the v5. All now applied for -next.
I reworded the first commit message slightly and added a stable tag
since it clearly fixes a bug even if it happens to have been around
since 2005 without anyone noticing.
And thanks again for doing this work. The code is indeed much easier to
read now, and provides a good foundation for further improvements.
Johan
prev parent reply other threads:[~2016-05-05 10:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 21:56 [PATCH v5 0/3] USB: serial: cp210x: Bugfixes and cleanup in CRTSCTS flag code Konstantin Shkolnyy
2016-05-05 10:00 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160505100010.GM1367@localhost \
--to=johan@kernel.org \
--cc=konstantin.shkolnyy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox