From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: venkat.prashanth2498@gmail.com
Cc: a.zummo@towertech.it, marcus.folkesson@gmail.com,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: add support for maxim rtc max6916
Date: Thu, 5 May 2016 12:53:51 +0200 [thread overview]
Message-ID: <20160505105351.GA2890@piout.net> (raw)
In-Reply-To: <1462442989-3894-1-git-send-email-venkat.prashanth2498@gmail.com>
Hi,
On 05/05/2016 at 03:09:49 -0700, venkat.prashanth2498@gmail.com wrote :
> From: venkat-prashanth <venkat.prashanth2498@gmail.com>
>
> This a patch to add support for
> maxim rtc max6916
>
> Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
> ---
> ---
> drivers/rtc/rtc-max6916.c | 165 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 165 insertions(+)
>
This is the second version you send since my comments. Please include
the patch version in the subject line.
Also, you need to include a changelog.
Finally, you didn't address many of my comments please do so before
submitting again.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-05-05 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 10:09 [PATCH] rtc: add support for maxim rtc max6916 venkat.prashanth2498
2016-05-05 10:53 ` Alexandre Belloni [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-05-04 10:30 [PATCH] rtc:add " venkat.prashanth2498
2016-05-04 11:51 ` Marcus Folkesson
2016-05-03 11:07 [PATCH] rtc: add " venkat.prashanth2498
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160505105351.GA2890@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=rtc-linux@googlegroups.com \
--cc=venkat.prashanth2498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox