From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757345AbcEEKxz (ORCPT ); Thu, 5 May 2016 06:53:55 -0400 Received: from down.free-electrons.com ([37.187.137.238]:49914 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756675AbcEEKxx (ORCPT ); Thu, 5 May 2016 06:53:53 -0400 Date: Thu, 5 May 2016 12:53:51 +0200 From: Alexandre Belloni To: venkat.prashanth2498@gmail.com Cc: a.zummo@towertech.it, marcus.folkesson@gmail.com, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: add support for maxim rtc max6916 Message-ID: <20160505105351.GA2890@piout.net> References: <1462442989-3894-1-git-send-email-venkat.prashanth2498@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462442989-3894-1-git-send-email-venkat.prashanth2498@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 05/05/2016 at 03:09:49 -0700, venkat.prashanth2498@gmail.com wrote : > From: venkat-prashanth > > This a patch to add support for > maxim rtc max6916 > > Signed-off-by: Venkat Prashanth B U > --- > --- > drivers/rtc/rtc-max6916.c | 165 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 165 insertions(+) > This is the second version you send since my comments. Please include the patch version in the subject line. Also, you need to include a changelog. Finally, you didn't address many of my comments please do so before submitting again. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com