From: Christoph Hellwig <hch@infradead.org>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: dan.j.williams@intel.com, david@fromorbit.com, jack@suse.cz,
linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org,
micah.parrish@hpe.com, hch@infradead.org,
adilger.kernel@dilger.ca, linux-fsdevel@vger.kernel.org,
tytso@mit.edu
Subject: Re: [PATCH v2-UPDATE 3/3] xfs: Add alignment check for DAX mount
Date: Thu, 5 May 2016 07:21:44 -0700 [thread overview]
Message-ID: <20160505142144.GA3601@infradead.org> (raw)
In-Reply-To: <1462376761-15584-1-git-send-email-toshi.kani@hpe.com>
> if (mp->m_flags & XFS_MOUNT_DAX) {
> + struct blk_dax_ctl dax = {
> + .sector = 0,
> + .size = PAGE_SIZE,
> + };
I'm pretty sure I already complained last week, but this boiler plate
code has no business in every file systems. Also it seems to me like
this struct blk_dax_ctl calling convention is stupid to start with,
why not pass the arguments directly and avoid the boilerplate code
everywhere?
next prev parent reply other threads:[~2016-05-05 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 15:46 [PATCH v2-UPDATE 3/3] xfs: Add alignment check for DAX mount Toshi Kani
2016-05-05 14:21 ` Christoph Hellwig [this message]
2016-05-05 14:19 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160505142144.GA3601@infradead.org \
--to=hch@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=micah.parrish@hpe.com \
--cc=toshi.kani@hpe.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox