From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757359AbcEEOxZ (ORCPT ); Thu, 5 May 2016 10:53:25 -0400 Received: from imap.thunk.org ([74.207.234.97]:50050 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753426AbcEEOxY (ORCPT ); Thu, 5 May 2016 10:53:24 -0400 Date: Thu, 5 May 2016 14:53:17 +0000 From: tytso@mit.edu To: Jan Kara Cc: Seth Forshee , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: Fix check of dqget() return value in ext4_ioctl_setproject() Message-ID: <20160505145317.GA17625@thunk.org> Mail-Followup-To: tytso@mit.edu, Jan Kara , Seth Forshee , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <1459256463-48543-1-git-send-email-seth.forshee@canonical.com> <20160422183632.GC109717@ubuntu-hedt> <20160505125234.GF1970@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160505125234.GF1970@quack2.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2016 at 02:52:34PM +0200, Jan Kara wrote: > On Fri 22-04-16 13:36:32, Seth Forshee wrote: > > On Tue, Mar 29, 2016 at 08:01:03AM -0500, Seth Forshee wrote: > > > A failed call to dqget() returns an ERR_PTR() and not null. Fix > > > the check in ext4_ioctl_setproject() to handle this correctly. > > > > > > Fixes: 9b7365fc1c82 ("ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support") > > > Cc: stable@vger.kernel.org # v4.5 > > > Signed-off-by: Seth Forshee > > > > Thought I'd check and see if this patch was forgotten, I sent it nearly > > a month ago but the bug is still present. > > Yeah, it seems Ted forgot to pull the fix. Ted? BTW, feel free to add > > Reviewed-by: Jan Kara Applied, thanks. - Ted