From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755279AbcEESfZ (ORCPT ); Thu, 5 May 2016 14:35:25 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33971 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751844AbcEESfY (ORCPT ); Thu, 5 May 2016 14:35:24 -0400 Date: Fri, 6 May 2016 00:05:12 +0530 From: Muhammad Falak R Wani To: Christoph Hellwig Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: partition: use RCU_INIT_POINTER() for NULLing. Message-ID: <20160505183512.GA10821@kp> References: <1462470846-10446-1-git-send-email-falakreyaz@gmail.com> <20160505183119.GA12271@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160505183119.GA12271@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2016 at 11:31:19AM -0700, Christoph Hellwig wrote: > On Thu, May 05, 2016 at 11:24:06PM +0530, Muhammad Falak R Wani wrote: > > It is safe to use RCU_INIT_POINTER() to NULL, instead of > > rcu_assign_pointer(). > > This results in slightly smaller/faster code. > > > > Signed-off-by: Muhammad Falak R Wani > > Muhammad, > > please stop sending these patches. They make the code less reusbale, > and we (or rather Paul) are working on making rcu_assign_pointer do > the right thing. Sorry, my bad! Wont send any of these now. I just thought it might be the right thing to do, till the time Paul et al make it do the right thing. -mfrw