From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756767AbcEEUHb (ORCPT ); Thu, 5 May 2016 16:07:31 -0400 Received: from mail.kernel.org ([198.145.29.136]:58340 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754076AbcEEUHa (ORCPT ); Thu, 5 May 2016 16:07:30 -0400 Date: Thu, 5 May 2016 17:07:23 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Peter Zijlstra , Zefan Li , pi3orama@163.com Subject: Re: [PATCH v2 3/4] perf tools: Support reading from backward ring buffer Message-ID: <20160505200723.GI11069@kernel.org> References: <1461723563-67451-1-git-send-email-wangnan0@huawei.com> <1461723563-67451-4-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461723563-67451-4-git-send-email-wangnan0@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Apr 27, 2016 at 02:19:22AM +0000, Wang Nan escreveu: > perf_evlist__mmap_read_backward() is introduced for reading backward > ring buffer. Different from reading forward, before reading, caller > needs to call perf_evlist__mmap_read_catchup() first. > > Backward ring buffer should be read from 'head' pointer, not '0'. > perf_evlist__mmap_read_catchup() saves 'head' to 'md->prev', then > make it remember the start position after each reading. > > Signed-off-by: Wang Nan > Cc: Arnaldo Carvalho de Melo > Cc: Peter Zijlstra > Cc: Zefan Li > Cc: pi3orama@163.com > --- > tools/perf/util/evlist.c | 39 +++++++++++++++++++++++++++++++++++++++ > tools/perf/util/evlist.h | 4 ++++ > 2 files changed, 43 insertions(+) > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index 17cd014..2e0b7b0 100644 > --- a/tools/perf/util/evlist.c > +++ b/tools/perf/util/evlist.c > @@ -766,6 +766,45 @@ union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx) > return perf_mmap__read(md, evlist->overwrite, old, head, &md->prev); > } > > +union perf_event * > +perf_evlist__mmap_read_backward(struct perf_evlist *evlist, int idx) > +{ > + struct perf_mmap *md = &evlist->mmap[idx]; > + u64 head, end; > + u64 start = md->prev; > + > + /* > + * Check if event was unmapped due to a POLLHUP/POLLERR. > + */ > + if (!atomic_read(&md->refcnt)) > + return NULL; > + > + /* NOTE: head is negative in this case */ What is this comment for, can you ellaborate? Are you double sure this arithmetic with u64, negative values, that -head below are all ok? I've applied the first two patches in this series. I also need to check why we now need that catchup thing :-\ > + head = perf_mmap__read_head(md); > + > + if (!head) > + return NULL; > + > + end = head + md->mask + 1; > + > + if ((end - head) > -head) > + end = 0; > + > + return perf_mmap__read(md, false, start, end, &md->prev); > +} > + > +void perf_evlist__mmap_read_catchup(struct perf_evlist *evlist, int idx) > +{ > + struct perf_mmap *md = &evlist->mmap[idx]; > + u64 head; > + > + if (!atomic_read(&md->refcnt)) > + return; > + > + head = perf_mmap__read_head(md); > + md->prev = head; > +} > + > static bool perf_mmap__empty(struct perf_mmap *md) > { > return perf_mmap__read_head(md) == md->prev && !md->auxtrace_mmap.base; > diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h > index 208897a..85d1b59 100644 > --- a/tools/perf/util/evlist.h > +++ b/tools/perf/util/evlist.h > @@ -129,6 +129,10 @@ struct perf_sample_id *perf_evlist__id2sid(struct perf_evlist *evlist, u64 id); > > union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx); > > +union perf_event *perf_evlist__mmap_read_backward(struct perf_evlist *evlist, > + int idx); > +void perf_evlist__mmap_read_catchup(struct perf_evlist *evlist, int idx); > + > void perf_evlist__mmap_consume(struct perf_evlist *evlist, int idx); > > int perf_evlist__open(struct perf_evlist *evlist); > -- > 1.8.3.4