From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [RFC PATCH net-next 01/20] net: dsa: mv88e6xxx: factorize PHY access with PPU
Date: Fri, 6 May 2016 00:54:31 +0200 [thread overview]
Message-ID: <20160505225431.GG7972@lunn.ch> (raw)
In-Reply-To: <1462488064-1841-2-git-send-email-vivien.didelot@savoirfairelinux.com>
On Thu, May 05, 2016 at 06:40:45PM -0400, Vivien Didelot wrote:
> Add a flags bitmap to the mv88e6xxx_info structure to help describing
> features supported or not by a switch model.
>
> Add a MV88E6XXX_FLAG_PPU flag to describe switch models with a PHY
> Polling Unit. This allows to merge PPU specific PHY access code in the
> share code. In the meantime, use unlocked register accesses.
>
> Since the PPU code is shared, also remove NET_DSA_MV88E6XXX_NEED_PPU.
> -#ifdef CONFIG_NET_DSA_MV88E6XXX_NEED_PPU
> -static int mv88e6xxx_ppu_disable(struct mv88e6xxx_priv_state *ps)
> +static int _mv88e6xxx_ppu_enable(struct mv88e6xxx_priv_state *ps, bool enable)
> {
> - int ret;
The change log does not say anything about refactoring
mv88e6xxx_ppu_disable() and mv88e6xxx_ppu_enable() into one function.
That should be in separate patch. Also, i don't see much value in this
refactoring. The names mv88e6xxx_ppu_disable() and
mv88e6xxx_ppu_enable() are much clearer than having one function which
takes a bool.
Andrew
next prev parent reply other threads:[~2016-05-05 22:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 22:40 [RFC PATCH net-next 00/20] net: dsa: mv88e6xxx: turn into monolithic driver Vivien Didelot
2016-05-05 22:40 ` [RFC PATCH net-next 01/20] net: dsa: mv88e6xxx: factorize PHY access with PPU Vivien Didelot
2016-05-05 22:54 ` Andrew Lunn [this message]
2016-05-05 22:59 ` Andrew Lunn
2016-05-05 23:06 ` Andrew Lunn
2016-05-05 22:40 ` [RFC PATCH net-next 02/20] net: dsa: mv88e6xxx: factorize PHY indirect access Vivien Didelot
2016-05-05 22:40 ` [RFC PATCH net-next 03/20] net: dsa: mv88e6xxx: factorize EEPROM access Vivien Didelot
2016-05-05 22:40 ` [RFC PATCH net-next 04/20] net: dsa: mv88e6xxx: factorize temperature access Vivien Didelot
2016-05-05 23:40 ` Andrew Lunn
2016-05-05 22:40 ` [RFC PATCH net-next 05/20] net: dsa: mv88e6xxx: factorize MAC address setting Vivien Didelot
2016-05-05 22:40 ` [RFC PATCH net-next 06/20] net: dsa: mv88e6xxx: factorize EEE access Vivien Didelot
2016-05-05 22:40 ` [RFC PATCH net-next 07/20] net: dsa: mv88e6xxx: factorize registers access Vivien Didelot
2016-05-05 22:40 ` [RFC PATCH net-next 08/20] net: dsa: mv88e6xxx: factorize bridge support Vivien Didelot
2016-05-05 22:40 ` [RFC PATCH net-next 09/20] net: dsa: mv88e6xxx: factorize VTU access Vivien Didelot
2016-05-05 22:40 ` [RFC PATCH net-next 10/20] net: dsa: mv88e6xxx: factorize ATU access Vivien Didelot
2016-05-05 22:40 ` [RFC PATCH net-next 11/20] net: dsa: mv88e6xxx: factorize switch reset Vivien Didelot
2016-05-05 22:40 ` [RFC PATCH net-next 12/20] net: dsa: mv88e6xxx: factorize global setup Vivien Didelot
2016-05-05 22:40 ` [RFC PATCH net-next 13/20] net: dsa: mv88e6xxx: factorize GLOBAL_CONTROL setup Vivien Didelot
2016-05-06 0:55 ` Andrew Lunn
2016-05-05 22:40 ` [RFC PATCH net-next 14/20] net: dsa: mv88e6xxx: factorize VLAN Ethertype Vivien Didelot
2016-05-06 0:57 ` Andrew Lunn
2016-05-06 15:12 ` Vivien Didelot
2016-05-05 22:40 ` [RFC PATCH net-next 15/20] net: dsa: mv88e6xxx: factorize GLOBAL_MONITOR_CONTROL setup Vivien Didelot
2016-05-05 22:41 ` [RFC PATCH net-next 16/20] net: dsa: mv88e6xxx: factorize GLOBAL_CONTROL_2 setup Vivien Didelot
2016-05-05 22:41 ` [RFC PATCH net-next 17/20] net: dsa: mv88e6xxx: factorize frames priorities Vivien Didelot
2016-05-05 22:41 ` [RFC PATCH net-next 18/20] net: dsa: mv88e6xxx: factorize switch setup Vivien Didelot
2016-05-05 22:41 ` [RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol Vivien Didelot
2016-05-06 1:09 ` Andrew Lunn
2016-05-06 20:56 ` Vivien Didelot
2016-05-05 22:41 ` [RFC PATCH net-next 20/20] net: dsa: mv88e6xxx: factorize the switch driver Vivien Didelot
2016-05-06 1:14 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160505225431.GG7972@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox