From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757845AbcEEW7r (ORCPT ); Thu, 5 May 2016 18:59:47 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:57958 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752560AbcEEW7q (ORCPT ); Thu, 5 May 2016 18:59:46 -0400 Date: Fri, 6 May 2016 00:59:44 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [RFC PATCH net-next 01/20] net: dsa: mv88e6xxx: factorize PHY access with PPU Message-ID: <20160505225944.GH7972@lunn.ch> References: <1462488064-1841-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1462488064-1841-2-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462488064-1841-2-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -static int mv88e6xxx_ppu_access_get(struct mv88e6xxx_priv_state *ps) > +static int _mv88e6xxx_ppu_access_get(struct mv88e6xxx_priv_state *ps) Hi Vivien We agreed to stop adding _ to functions that assume the lock has been taken. Now that we check the lock is held in lowest level function, it quickly becomes clear if the locks are wrong. It either deadlocks, or it prints a warning when there is an error. Please don't rename these functions. Andrew