From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932093AbcEEXHD (ORCPT ); Thu, 5 May 2016 19:07:03 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:57978 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753798AbcEEXHC (ORCPT ); Thu, 5 May 2016 19:07:02 -0400 Date: Fri, 6 May 2016 01:06:59 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [RFC PATCH net-next 01/20] net: dsa: mv88e6xxx: factorize PHY access with PPU Message-ID: <20160505230659.GI7972@lunn.ch> References: <1462488064-1841-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1462488064-1841-2-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462488064-1841-2-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > { > struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); > int addr = mv88e6xxx_port_to_phy_addr(ps, port); > - int ret; > + int err; > > if (addr < 0) > return 0xffff; > > + We don't want an extra blank line. I'm surprised checkpatch did not warn about this. > mutex_lock(&ps->smi_mutex); > - ret = _mv88e6xxx_phy_write(ps, addr, regnum, val); > + > + if (mv88e6xxx_has(ps, MV88E6XXX_FLAG_PPU)) > + err = _mv88e6xxx_phy_write_ppu(ps, addr, regnum, val); > + else > + err = _mv88e6xxx_phy_write(ps, addr, regnum, val); > + > mutex_unlock(&ps->smi_mutex); > - return ret; > + > + return err; Please don't rename ret to err. This patch is about phy reading and writing, and i don't expect to see anything else here. It makes it harder to review. Andrew