From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757148AbcEEXkh (ORCPT ); Thu, 5 May 2016 19:40:37 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:57995 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754614AbcEEXkg (ORCPT ); Thu, 5 May 2016 19:40:36 -0400 Date: Fri, 6 May 2016 01:40:33 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [RFC PATCH net-next 04/20] net: dsa: mv88e6xxx: factorize temperature access Message-ID: <20160505234033.GJ7972@lunn.ch> References: <1462488064-1841-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1462488064-1841-5-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462488064-1841-5-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > int mv88e6xxx_get_temp(struct dsa_switch *ds, int *temp) > { > struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); > + int err; > + > + if (!mv88e6xxx_has(ps, MV88E6XXX_FLAG_TEMP)) > + return -EOPNOTSUPP; > + > + mutex_lock(&ps->smi_mutex); > > if (mv88e6xxx_6320_family(ps) || mv88e6xxx_6352_family(ps)) > - return mv88e63xx_get_temp(ds, temp); > + err = _mv88e63xx_get_temp(ps, temp); > + else > + err = _mv88e61xx_get_temp(ps, temp); It seems like this should be done with a flag, rather than the family. However, don't spend too much time on this. I plan to rip it all out and put it in the correct place, in the Marvell PHY driver. The temperature sensor is in the PHY, and other Marvell PHYs also have this temperature sensor. Andrew