From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756693AbcEEXtS (ORCPT ); Thu, 5 May 2016 19:49:18 -0400 Received: from mail.kernel.org ([198.145.29.136]:41003 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754614AbcEEXtQ (ORCPT ); Thu, 5 May 2016 19:49:16 -0400 Date: Thu, 5 May 2016 20:49:12 -0300 From: Arnaldo Carvalho de Melo To: Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, Namhyung Kim , Peter Zijlstra , Ingo Molnar Subject: Re: [PATCH perf/core v2 1/8] perf: Rewrite strbuf not to die Message-ID: <20160505234912.GM11069@kernel.org> References: <20160429150941.30063.62888.stgit@devbox> <20160429150950.30063.39517.stgit@devbox> <20160505232538.GK11069@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160505232538.GK11069@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, May 05, 2016 at 08:25:38PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Sat, Apr 30, 2016 at 12:09:50AM +0900, Masami Hiramatsu escreveu: > > @@ -112,12 +151,14 @@ ssize_t strbuf_read(struct strbuf *sb, int fd, ssize_t hint) > > strbuf_release(sb); > > else > > strbuf_setlen(sb, oldlen); > > - return -1; > > + return cnt; > > This is unrelated, no? > > I.e. this _was_ already returning a failure code, but then you are > propagating the read() return, which may even be a good idea, haven't > thought about that, but is unrelated to what this patch is doing, please > put it in a separate patch if you think it is a good idea. > > All the rest seems ok, going over the other patches now. Just a bit annoying, but this is done when checking if cnt < 0, which can only be -1 as per read's man page, so its ok, nevermind... - Arnaldo