From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756364AbcEEXzX (ORCPT ); Thu, 5 May 2016 19:55:23 -0400 Received: from mail.kernel.org ([198.145.29.136]:41294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752560AbcEEXzW (ORCPT ); Thu, 5 May 2016 19:55:22 -0400 Date: Thu, 5 May 2016 20:55:18 -0300 From: Arnaldo Carvalho de Melo To: Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, Namhyung Kim , Peter Zijlstra , Ingo Molnar Subject: Re: [PATCH perf/core v2 5/8] perf header: Make topology checkers to check return value of strbuf Message-ID: <20160505235518.GP11069@kernel.org> References: <20160429150941.30063.62888.stgit@devbox> <20160429151033.30063.91049.stgit@devbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160429151033.30063.91049.stgit@devbox> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sat, Apr 30, 2016 at 12:10:33AM +0900, Masami Hiramatsu escreveu: > Make topology checkers to check the return value of strbuf > APIs so that it can detect errors in it. > } > @@ -1907,7 +1910,7 @@ static int process_numa_topology(struct perf_file_section *section __maybe_unuse > u32 nr, node, i; > char *str; > uint64_t mem_total, mem_free; > - struct strbuf sb; > + struct strbuf sb = STRBUF_INIT; Since you're going to call strbuf_init() later, is the above really needed? > /* nr nodes */ > ret = readn(fd, &nr, sizeof(nr)); > @@ -1918,7 +1921,8 @@ static int process_numa_topology(struct perf_file_section *section __maybe_unuse > nr = bswap_32(nr); > > ph->env.nr_numa_nodes = nr; > - strbuf_init(&sb, 256); > + if (strbuf_init(&sb, 256) < 0) > + goto error; >