From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756877AbcEFAzv (ORCPT ); Thu, 5 May 2016 20:55:51 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:58022 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753003AbcEFAzt (ORCPT ); Thu, 5 May 2016 20:55:49 -0400 Date: Fri, 6 May 2016 02:55:46 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [RFC PATCH net-next 13/20] net: dsa: mv88e6xxx: factorize GLOBAL_CONTROL setup Message-ID: <20160506005546.GK7972@lunn.ch> References: <1462488064-1841-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1462488064-1841-14-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462488064-1841-14-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2016 at 06:40:57PM -0400, Vivien Didelot wrote: > All switch models configure the GLOBAL_CONTROL register with slightly > differences. And as far as i know, we have no idea why. > Assume a common setup to enable the PHY Polling Unit if present, discard > packets with excessive collisions, set the maximum frame size to 1632, > and mask all interrupt sources. This is a behaviour change, not just a refactor. It would be good to say on which families it has been tested, and which have not. Andrew