From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757801AbcEFA6E (ORCPT ); Thu, 5 May 2016 20:58:04 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:58027 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754211AbcEFA6B (ORCPT ); Thu, 5 May 2016 20:58:01 -0400 Date: Fri, 6 May 2016 02:57:59 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [RFC PATCH net-next 14/20] net: dsa: mv88e6xxx: factorize VLAN Ethertype Message-ID: <20160506005759.GL7972@lunn.ch> References: <1462488064-1841-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1462488064-1841-15-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462488064-1841-15-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2016 at 06:40:58PM -0400, Vivien Didelot wrote: > Only the 6131 driver was setting the VLAN Ethertype to 0x8100. Set it to > all models. > > Signed-off-by: Vivien Didelot > --- > drivers/net/dsa/mv88e6131.c | 9 ++++----- > drivers/net/dsa/mv88e6xxx.c | 8 ++++++++ > drivers/net/dsa/mv88e6xxx.h | 7 +++++++ > 3 files changed, 19 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/dsa/mv88e6131.c b/drivers/net/dsa/mv88e6131.c > index 013668c..4c0b1e9 100644 > --- a/drivers/net/dsa/mv88e6131.c > +++ b/drivers/net/dsa/mv88e6131.c > @@ -25,6 +25,7 @@ static const struct mv88e6xxx_info mv88e6131_table[] = { > .num_databases = 256, > .num_ports = 11, > .flags = MV88E6XXX_FLAG_ATU | > + MV88E6XXX_FLAG_CORE_TAG_TYPE | > MV88E6XXX_FLAG_PPU | > MV88E6XXX_FLAG_VLANTABLE | > MV88E6XXX_FLAG_VTU, > @@ -35,6 +36,7 @@ static const struct mv88e6xxx_info mv88e6131_table[] = { > .num_databases = 4096, > .num_ports = 10, > .flags = MV88E6XXX_FLAG_ATU | > + MV88E6XXX_FLAG_CORE_TAG_TYPE | > MV88E6XXX_FLAG_PPU | > MV88E6XXX_FLAG_VLANTABLE | > MV88E6XXX_FLAG_VTU, > @@ -45,6 +47,7 @@ static const struct mv88e6xxx_info mv88e6131_table[] = { > .num_databases = 256, > .num_ports = 8, > .flags = MV88E6XXX_FLAG_ATU | > + MV88E6XXX_FLAG_CORE_TAG_TYPE | > MV88E6XXX_FLAG_PPU | > MV88E6XXX_FLAG_VLANTABLE | > MV88E6XXX_FLAG_VTU, > @@ -55,6 +58,7 @@ static const struct mv88e6xxx_info mv88e6131_table[] = { > .num_databases = 256, > .num_ports = 10, > .flags = MV88E6XXX_FLAG_ATU | > + MV88E6XXX_FLAG_CORE_TAG_TYPE | > MV88E6XXX_FLAG_PPU | > MV88E6XXX_FLAG_VLANTABLE | > MV88E6XXX_FLAG_VTU, Hi Vivien Rather than repeating these flags again and again, could you add one #define containing the flags, and then use that to initialise .flags. Andrew