From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756279AbcEFBJx (ORCPT ); Thu, 5 May 2016 21:09:53 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:58037 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754196AbcEFBJw (ORCPT ); Thu, 5 May 2016 21:09:52 -0400 Date: Fri, 6 May 2016 03:09:49 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol Message-ID: <20160506010949.GM7972@lunn.ch> References: <1462488064-1841-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1462488064-1841-20-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462488064-1841-20-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2016 at 06:41:03PM -0400, Vivien Didelot wrote: > 6131 is the only driver to set the tag protocol to DSA_TAG_PROTO_DSA. > Since it works fine with DSA_TAG_PROTO_EDSA, change its value, like all > other mv88e6xxx drivers. Hi Vivien You might as well remove net/dsa/tag_dsa.c as well, since it is now unused. Please do that as a separate patch. Andrew