From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758049AbcEFKK4 (ORCPT ); Fri, 6 May 2016 06:10:56 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:34919 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751789AbcEFKKy (ORCPT ); Fri, 6 May 2016 06:10:54 -0400 Date: Fri, 6 May 2016 12:10:48 +0200 From: Ingo Molnar To: Borislav Petkov Cc: Kees Cook , torvalds@linux-foundation.org, hpa@zytor.com, dyoung@redhat.com, tglx@linutronix.de, luto@kernel.org, peterz@infradead.org, dvlasenk@redhat.com, linux-kernel@vger.kernel.org, brgerst@gmail.com, luto@amacapital.net, akpm@linux-foundation.org, bhe@redhat.com, yinghai@kernel.org, vgoyal@redhat.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/boot] x86/boot: Clean up pointer casting Message-ID: <20160506101048.GA7325@gmail.com> References: <1462486436-3707-2-git-send-email-keescook@chromium.org> <20160506085300.GE24044@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160506085300.GE24044@pd.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > This can be simplified even further: > > --- > From: Borislav Petkov > Date: Fri, 6 May 2016 10:43:21 +0200 > Subject: [PATCH] x86/boot: Simplify pointer casting in > choose_random_location() > > Pass them down as unsigned long directly and get rid of more casting and > assignments. > > Signed-off-by: Borislav Petkov > Cc: Kees Cook > arch/x86/boot/compressed/misc.h | 8 ++++---- > 3 files changed, 12 insertions(+), 16 deletions(-) Great, thanks! Ingo